From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.250]) by sourceware.org (Postfix) with ESMTPS id 39B2A385B835 for ; Fri, 17 Apr 2020 20:20:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 39B2A385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id D3D88A25D for ; Fri, 17 Apr 2020 15:20:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PXTTjy9aa1s2xPXTTjbC0x; Fri, 17 Apr 2020 15:20:31 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zvY+/UvlZkQOzozh/0ihM6S21u+rkJz6D4YkFHWNlqg=; b=xnYEX8QKkKeZTLuWtNgqUXmhBE bPmFXrGdF8AgSvOCXxkbe2FkLmerjE6cZ0yMsritJEH6RMr45XqwqNpZFGMMlh/3raCxURzPXLNmu kw2GTQa2V0qYretWPf/h3q31H; Received: from 174-16-123-2.hlrn.qwest.net ([174.16.123.2]:53146 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jPXTT-002XuG-I5; Fri, 17 Apr 2020 14:20:31 -0600 From: Tom Tromey To: Pedro Alves via Gdb-patches Cc: Pedro Alves Subject: Re: [PATCH 00/28] Decouple inferior_ptid/inferior_thread(); dup ptids in thread list (PR/25412) References: <20200414175434.8047-1-palves@redhat.com> X-Attribution: Tom Date: Fri, 17 Apr 2020 14:20:30 -0600 In-Reply-To: <20200414175434.8047-1-palves@redhat.com> (Pedro Alves via Gdb-patches's message of "Tue, 14 Apr 2020 18:54:06 +0100") Message-ID: <87y2qtq2y9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.123.2 X-Source-L: No X-Exim-ID: 1jPXTT-002XuG-I5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-123-2.hlrn.qwest.net (murgatroyd) [174.16.123.2]:53146 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 20:20:34 -0000 >>>>> "Pedro" == Pedro Alves via Gdb-patches writes: I meant to mention, I skimmed through this series and didn't see anything objectionable. It's hard to know about this kind of thing without trying it (which I didn't do); but IMO it's fine to land this and then iron out anything that pops up. Pedro> After this, inferior_ptid still exists, but it is mostly read-only and Pedro> mainly used by target backend code. Could it be made completely read-only? Pedro> It is also relied on by a number Pedro> of target methods as a global input argument. E.g., the target_resume Pedro> interface and the memory reading routines -- we still need it there Pedro> because we need to be able to access memory off of processes for which Pedro> we don't have a corresponding inferior/thread object, like when Pedro> handling forks. Maybe we could pass down a context explicitly to Pedro> target_read_memory, etc. This sounds like a good direction. Tom