From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Skip gdb.rust/*.exp for target board unix/-m32
Date: Wed, 20 Jan 2021 12:55:40 -0700 [thread overview]
Message-ID: <87y2gn4c3n.fsf@tromey.com> (raw)
In-Reply-To: <20210118084942.GA30245@delia> (Tom de Vries's message of "Mon, 18 Jan 2021 09:49:44 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Fix this by testing for -m32 in the target board multilib_flags in
Tom> skip_rust_tests.
Tom> Tested on x86_64-linux.
Tom> Any comments?
This seems fine. Thank you for doing this.
There is a way to run rustc that would work here, but it requires the
user to use cargo to install a second rust toolchain. So, maybe it's
not worth bothering with.
Tom
prev parent reply other threads:[~2021-01-20 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 8:49 Tom de Vries
2021-01-20 19:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2gn4c3n.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox