From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FvZdMBfyCWDGFAAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 16:28:55 -0500 Received: by simark.ca (Postfix, from userid 112) id B59171EF80; Thu, 21 Jan 2021 16:28:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D7841E590 for ; Thu, 21 Jan 2021 16:28:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9BD2384B110; Thu, 21 Jan 2021 21:28:54 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.13]) by sourceware.org (Postfix) with ESMTPS id AE597386186E for ; Thu, 21 Jan 2021 21:28:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE597386186E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 5174E1229F9 for ; Thu, 21 Jan 2021 15:28:52 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2hVclrnQcuDoA2hVcl1ptL; Thu, 21 Jan 2021 15:28:52 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hW28X7FVDcBlfibiJov3Q+pHFHdAEaqpSemo4FjX4v8=; b=x4+B8TMGoyRNTRd7iWlZ8nZbk/ 0GHftPTuEZlTLrWKh32NjijkuWP9tk74JE0deLbfdT25Ys3xETm1p8FJODzOwmaKVx9pbEt1VplVM e6ChdCLl8EtsuboWo+CnyQMoX; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:35782 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2hVb-003ygV-Va; Thu, 21 Jan 2021 14:28:52 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 04/30] Move compilation unit info to dwarf_expr_context References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-5-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Thu, 21 Jan 2021 14:28:50 -0700 In-Reply-To: <20201207190031.13341-5-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:05 +0000") Message-ID: <87y2gmq8rx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2hVb-003ygV-Va X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:35782 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> This patch moves the compilation unit context information and support Zoran> from dwarf_expr_executor and dwarf_evaluate_loc_desc to Zoran> dwarf_expr_context evaluator. The idea is to report an error when a Zoran> given operation requires a compilation unit information to be resolved, Zoran> which is not available. Thank you for the patch. Zoran> +/* Ensure that a PER_CU is defined and throw an exception otherwise. */ Zoran> + Zoran> +static void Zoran> +ensure_have_per_cu (struct dwarf2_per_cu_data *per_cu, const char* op_name) Zoran> +{ Zoran> + if (per_cu == nullptr) Zoran> + throw_error (GENERIC_ERROR, Zoran> + _("%s evaluation requires a compilation unit."), op_name); One thing I didn't think to ask about in an earlier patch is -- why throw_error with GENERIC_ERROR here? Unless there's a specific reason, in gdb it's normal to use plain 'error' instead. Other than that, this seems fine. Tom