From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id f2AUFnsuKGAKeAAAWB0awg (envelope-from ) for ; Sat, 13 Feb 2021 14:54:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 4B59C1EF68; Sat, 13 Feb 2021 14:54:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E35611E789 for ; Sat, 13 Feb 2021 14:54:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98FC9385803D; Sat, 13 Feb 2021 19:54:34 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.196.18]) by sourceware.org (Postfix) with ESMTPS id 35F23385803D for ; Sat, 13 Feb 2021 19:54:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 35F23385803D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C0A3E1011 for ; Sat, 13 Feb 2021 13:54:31 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id B0zvlUFwtDT64B0zvlFf0D; Sat, 13 Feb 2021 13:54:31 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=awlPSqepyDJGDHflAs0oXwc8Acl0hh64QgBNb3k2BX4=; b=pf+IBbIoXHhQy9+5EO0B0GEfmR cWhiHm1UzWavW26ihA6keSJcQfkyo2nGS/LXb0uwBFYkDLN3JUsHK3op5hkQnn5Ww+zFgjcgPFYyB 1RvSu1lImHPXmlEvWwt6RI1++; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:52434 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lB0zv-001dBF-Er; Sat, 13 Feb 2021 12:54:31 -0700 From: Tom Tromey To: Joel Brobecker Subject: Re: [PATCH 000/203] Refactor expressions References: <20210101214723.1784144-1-tom@tromey.com> <20210103070250.GC285722@adacore.com> X-Attribution: Tom Date: Sat, 13 Feb 2021 12:54:30 -0700 In-Reply-To: <20210103070250.GC285722@adacore.com> (Joel Brobecker's message of "Sun, 3 Jan 2021 11:02:50 +0400") Message-ID: <87y2fru4jt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1lB0zv-001dBF-Er X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:52434 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Joel" == Joel Brobecker writes: Joel> For me, I've gone through the patches, more or less carefully Joel> based on a random sample, and they look good. I paused a bit Joel> about the Ada ones, were you excluded the hanlding of noside == Joel> EVAL_SKIP. I'm not entirely sure why that is, perhaps because Joel> the block consists in a goto nosideret? Looking at what that Joel> nosideret does, it's just... Joel> | nosideret: Joel> | return eval_skip_value (exp); Joel> ... so we could inline this in the new functions. There's no need for EVAL_SKIP in the new code. This was just an artifact of how the expression objects were laid out in memory. It's possible that this series has intermediate states that fail in some way. I didn't test every patch in isolation. I suppose I should do that, I have just been avoiding it since on my home machine, a test run is ~15 minutes, which works out to 50 hours for this series. I'm ready to send v2 of the series. I think I'll save the individual regression test and fixes for v3. Tom