From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KAh2Niipw2D0egAAWB0awg (envelope-from ) for ; Fri, 11 Jun 2021 14:19:20 -0400 Received: by simark.ca (Postfix, from userid 112) id D7B781F163; Fri, 11 Jun 2021 14:19:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 04E6B1E813 for ; Fri, 11 Jun 2021 14:19:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C30543889809 for ; Fri, 11 Jun 2021 18:19:19 +0000 (GMT) Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.44.20]) by sourceware.org (Postfix) with ESMTPS id B2EF23857C7B for ; Fri, 11 Jun 2021 18:19:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2EF23857C7B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 7A255400C5FA1 for ; Fri, 11 Jun 2021 13:05:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rlkIlZsl1MRV2rlkIliF9T; Fri, 11 Jun 2021 13:19:06 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fikPnozpIMp2IvoZMRhYF66d+yhRLySzwCo755av5dQ=; b=VYvditzIP8GbO2qW1ulgWNn9Go TxFjFTBhqguShubALcV7hpGz0nE6uTVjtx6tPTLSxJSZq85Kwr0kpNX7TJwipl/3/RiKW630388ib O6z8Zas73MfA8EmhR9AwNLUtf; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:49752 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lrlkI-002eZ9-3S; Fri, 11 Jun 2021 12:19:06 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Subject: Re: [PATCH V5] CTF: multi-CU and archive support References: <1621297225-2332-1-git-send-email-weimin.pan@oracle.com> <20210610003512.auljolwwl5tmcrvx@Plymouth> X-Attribution: Tom Date: Fri, 11 Jun 2021 12:19:05 -0600 In-Reply-To: <20210610003512.auljolwwl5tmcrvx@Plymouth> (Lancelot SIX via Gdb-patches's message of "Thu, 10 Jun 2021 01:40:01 +0100") Message-ID: <87y2bgfena.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lrlkI-002eZ9-3S X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:49752 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: Lancelot> Should be Lancelot> if (sym != nullptr) Agreed. >> pst = new ctf_psymtab (name, partial_symtabs, objfile->per_bfd, 0); Lancelot> I am a bit confused by this one. As far as I can see, there is no way Lancelot> it can ever be deleted. Again, I am not so familiar with the code yet Lancelot> so I might have missed something, but hopefully not. psymtabs register themselves with a storage object. This is unfortunate but it is how it has been done for a long time, and nobody has bothered to clean it up. Tom