From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YHrIBC9vS2UFTwEAWB0awg (envelope-from ) for ; Wed, 08 Nov 2023 06:21:19 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TplKREMG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 053681E0C1; Wed, 8 Nov 2023 06:21:19 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8AD91E098 for ; Wed, 8 Nov 2023 06:21:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 914A13857704 for ; Wed, 8 Nov 2023 11:21:16 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 407A13858D3C for ; Wed, 8 Nov 2023 11:21:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 407A13858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 407A13858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699442467; cv=none; b=aycii/Tr6uztVRbu9gBcsD3VQ6CFrR93xWwkoc8RzDAoFGbE9az+blfnJSuKJrsz8eTpwMd1DmivjNcNW7ER+WLtNZZD4oq8DDfRw8oPO1bfS6T4N/iUmG2of0hoeijZo2hGPtgFH5xP4Y37/TisIWsOFwhcLgNpNwNsYT/mKZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699442467; c=relaxed/simple; bh=GYxftJrNvcwM3s2ABRiC19vVA85htqaHwNiBccCGBus=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZkcKYv/eHeqNszoUAF0jbEsQNJBTZPwpLGe/NbDVStza2U28UzOQVevHbKW3S3dHPXlaBlf1LoIZTWfiV2wzSpSoAY+f0kubIHNJDhGNzCfHjvwfCr552U9Fzt1HNXg2JzoLT/gpp1cQy1oc4oTOjZOj+ViFtCUOrv13I99p2WM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699442465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XzC25zzJfh92u5IkUe9/WjluMtUdHps5BvR+4xMRghg=; b=TplKREMGmCOBCIUugFzXqTwDVYp3sGZwsxULhVZw7j4KXrSzlMkfxWrEZcExpNsjeHaqH4 lCmlIscxvriMtAW9eylO5AxEpMiOCrZuVIX8NurVvlY4hrNi7CysXzhlCh5RE06U+AWHRb vGdRhhNUI0bw6LV9Aa66NPXY4OwpG5E= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-6f9KOo_qPfiJs16pEAkcNw-1; Wed, 08 Nov 2023 06:21:04 -0500 X-MC-Unique: 6f9KOo_qPfiJs16pEAkcNw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4090fa518bbso45358145e9.2 for ; Wed, 08 Nov 2023 03:21:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699442463; x=1700047263; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XzC25zzJfh92u5IkUe9/WjluMtUdHps5BvR+4xMRghg=; b=E1r4AnwW1ds2jSdncwdXBudB5Kyn5MkGexeUwZMUb5ryKn3w2O9NNg/Zgm3L++UMcj fJyLqVkKfi4rkWInbUil/cVw2xyLdtE/Ib8AdS8lq3wGTuWTCi+XwqkXLeDGZju/LSt4 FCKIpTBvEkVKDFf5QhCsjtAtMEtJTc2MNqpHk0Dg/Z9yD4pgO89B/pWTj2nShjXOqOcz GDC6uwmfr7BrYcNjjCyOzKvpCoaHOphz2B+Ww9LJsjqlDde5KbS3GgULmgyQ6AcXSWdP Z0MZlCyfMerbvVNcOEb9c2voad/jcJlQJ7GCbezRuAAMeEhyHv2iqChOgkpKa990aHm/ qU4g== X-Gm-Message-State: AOJu0YyCnfN4153VinwerP2hgWX5/unn3ZgRfWSpPqH2WY/zLqlbSsxb lMazjKl0lQMTQLtrxqFUYjV+Awg27oGxs56J5/v8MbGi+ZKjwXtIjDem4TpGV+EbhDsMKDlFcHL hJOaAQq0nZDKdkbrBDxFNvoaosRU46TtJkmMycKc+1mkiXthRpRopzbpkLhVozh/sYlGdZp2tRp 8gkqgiSg== X-Received: by 2002:a05:600c:4687:b0:409:231e:2a69 with SMTP id p7-20020a05600c468700b00409231e2a69mr1502807wmo.28.1699442463400; Wed, 08 Nov 2023 03:21:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3ajA2Bf0ouP/azkDIpQbrbfaXy6ileVCCOT3n+uUmARskl8ZGftEXS8xL3NW2NQyN1oC4Tg== X-Received: by 2002:a05:600c:4687:b0:409:231e:2a69 with SMTP id p7-20020a05600c468700b00409231e2a69mr1502786wmo.28.1699442462930; Wed, 08 Nov 2023 03:21:02 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id l41-20020a05600c1d2900b004083a105f27sm19142722wms.26.2023.11.08.03.21.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 03:21:02 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Improve disassemble command completion In-Reply-To: References: Date: Wed, 08 Nov 2023 11:21:01 +0000 Message-ID: <87y1f8sd7m.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Andrew Burgess writes: > I wanted better tab completion for the disassemble command. I've gone ahead and checked this series in. Thanks, Andrew > > --- > > Andrew Burgess (3): > gdb: error if /r and /b are used with disassemble command > gdb: make skip_over_slash_fmt available outside printcmd.c > gdb: add a custom command completer for disassemble command > > gdb/NEWS | 7 +++ > gdb/cli/cli-cmds.c | 20 ++++++++- > gdb/completer.c | 53 ++++++++++++++++++++++ > gdb/completer.h | 17 +++++++ > gdb/doc/gdb.texinfo | 20 ++++++--- > gdb/printcmd.c | 65 --------------------------- > gdb/testsuite/gdb.base/completion.exp | 30 +++++++++++++ > gdb/testsuite/gdb.disasm/basics.c | 22 +++++++++ > gdb/testsuite/gdb.disasm/basics.exp | 43 ++++++++++++++++++ > 9 files changed, 205 insertions(+), 72 deletions(-) > create mode 100644 gdb/testsuite/gdb.disasm/basics.c > create mode 100644 gdb/testsuite/gdb.disasm/basics.exp > > > base-commit: 1c37b30945073f34bbb685d2ac47ab01e0c93d45 > -- > 2.25.4