From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CiGYN2Hnw2VyoRYAWB0awg (envelope-from ) for ; Wed, 07 Feb 2024 15:26:09 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XkK2nrpG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D2C5E1E0C3; Wed, 7 Feb 2024 15:26:09 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCCE21E092 for ; Wed, 7 Feb 2024 15:26:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12BA33858283 for ; Wed, 7 Feb 2024 20:26:07 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id B8E2D3858C53 for ; Wed, 7 Feb 2024 20:25:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8E2D3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8E2D3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707337549; cv=none; b=nP0zpgA3wZc0q5TYDtXdLauehKghCuHbTJFtwkCDsdYDlwoeMO0h72e2U3NKRaDLQOdtgXJm6cPvUpmLCt6NGzrW6GDpczYq5jvafGVx3H7oA3N6E/IOZJN/fKcJ2GqBnfQyd2q0n/9+a7OAdYsAV01cyN7In7bORTtXt0UC4Nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707337549; c=relaxed/simple; bh=ALhcJwrJy+ndblZ80pblUzNm9nDzH10x/OTpMmu5RAI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tAsQyeBiY5eDgbfN9RjqlGsajyVtZ6srNNQPEau2yUws3BzNG4d9KZsEXqGr1Hr8VODFtuBTY83/X1jGKAizif1/24MyR+6maCMjwICOouxeuCKU4fGKkNBuaVsj/E5GJPwg5362uqCdpfKSqnYWh8tXrHrPzwZ9n0i8OFUfiw0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id XRS2rPFy2rh9zXoUMrkimv; Wed, 07 Feb 2024 20:25:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id XoULrz7nX41xUXoULrTBVm; Wed, 07 Feb 2024 20:25:46 +0000 X-Authority-Analysis: v=2.4 cv=ddgj3mXe c=1 sm=1 tr=0 ts=65c3e74a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=-vFTgF2qazbAh3DtDNUA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7vXDD8bvd2CmKNi9jsbu4U8GTKOJFEz1aesYgKpCCsE=; b=XkK2nrpGptNcuqBqEMWYtabHrG mFrtTPNHbyGqZ5hLy+BPeEdkTLsQfR60iGr01yQzgSL2qUug6rdlkkD0oOaad2486GcVCXWun+7k4 SCVzOlWcLFT2Mo2ess1AoKwDM; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:55300 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rXoUL-001L4o-0m; Wed, 07 Feb 2024 13:25:45 -0700 From: Tom Tromey To: Dmitry Neverov Cc: gdb-patches@sourceware.org Subject: Re: [RFC v2][PR symtab/30520] gdb/symtab: fix the gdb.cp/anon-struct test References: <20240123170325.752251-1-dmitry.neverov@jetbrains.com> <20240125084404.3536456-1-dmitry.neverov@jetbrains.com> X-Attribution: Tom Date: Wed, 07 Feb 2024 13:25:44 -0700 In-Reply-To: <20240125084404.3536456-1-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Thu, 25 Jan 2024 09:44:04 +0100") Message-ID: <87y1bw9g3b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rXoUL-001L4o-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:55300 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfO3f2eEmOlO1rNuaxTUcQ4Jom0NOBpsfT6zdrWy37xaaKE1KCm28RiBcPy6Xfhqs7BTkLye4/uDGjK9yhD7EPSn2vtcs+ty3g2DHvkTs4LCAoWkdyq1+ Gte98XKhPQAknWUb5JfPVFKOvZs7EadwEcGcHeA8IcVoTLGPiQir++8yJnOwdjvhF1w0br2gFsmKK+Bf/jiDIWXTYg7em7HJYCg= X-Spam-Status: No, score=-3016.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Dmitry" == Dmitry Neverov writes: Dmitry> The symbol_name_match_type::SEARCH_NAME cannot be used because Dmitry> demangle_for_lookup_info doesn't initialize a demangled name Dmitry> for it which makes a subsequent name matching to fail. I don't think I understand this comment, but anyway shouldn't this patch simply be folded into an earlier one in the series? I read through these and they seem basically reasonable to me -- in line with what I was hoping for. There are some minor formatting issues. You didn't mention what testing you did, so I am curious about that. thanks, Tom