From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Hr9dE2/cCmYfFR8AWB0awg (envelope-from ) for ; Mon, 01 Apr 2024 12:10:23 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oJ2nsFGK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3DEA11E030; Mon, 1 Apr 2024 12:10:23 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1AF331E030 for ; Mon, 1 Apr 2024 12:10:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 368A73858C55 for ; Mon, 1 Apr 2024 16:10:20 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 8D1ED3858D28 for ; Mon, 1 Apr 2024 16:09:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D1ED3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D1ED3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711987794; cv=none; b=CSVbe2GOk1IADKz82CqZMRZZ7hd6jlioGn8pitWTXAzexJneiEY2WyK0pdfqJ2l3w0cNI4UxCyuy232boFx9Y7m1BZCyl53SpOYbCjnj945GxOaFkSUXo+/tAEMroBJSq8Ef8UawpfADVxDo2g0W5HxgODuoi6m8gyTWa30pMiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711987794; c=relaxed/simple; bh=Jb4AA19u6SelErQFR6vRk+VYEhW8nYWXrHyuU+yYBpk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JIfm/29HcD+yd93u59/C80r0liMZJS94Da8nPLMNb23O0ahypXtD26XjwLzhfmKx/TBSnjXfEo5hZCeq+r2envnvDFJPX/qVCN3Gvx9hnDzsNyla7XnwFdM/wsBN439wz9EfzXM0erXBC0SRB/jJ/KRKj2lXA94pptd6ovnf3Hc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6005a.ext.cloudfilter.net ([10.0.30.201]) by cmsmtp with ESMTPS id rK6NrlWA6l9dRrKELrPrml; Mon, 01 Apr 2024 16:09:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rKEKrLA5hHHoArKEKrrISw; Mon, 01 Apr 2024 16:09:52 +0000 X-Authority-Analysis: v=2.4 cv=dskQCEg4 c=1 sm=1 tr=0 ts=660adc50 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=_yo-esS2K0uMPTytNlQA:9 a=zgiPjhLxNE0A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=n5WCqvNsevhhI/nz2Wis29mcR1s6gOtabs+nXx5jTGQ=; b=oJ2nsFGKrs5ybKgqszQ157FJE/ eN7bJ8p0eiIhzj4pyseCSwU+2e1vOe2bgKlTuHKsrj5kyoJjTetSDmsEtKhUoupsn2V/BExRWg1hK nU0HPhMXd91kM1Bgyl0MRER40; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:35176 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rrKEJ-001WEV-2r; Mon, 01 Apr 2024 10:09:51 -0600 From: Tom Tromey To: Lancelot SIX Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: ensure has dwarf info before reading DWZ file References: <20240330110121.2292510-1-lancelot.six@amd.com> X-Attribution: Tom Date: Mon, 01 Apr 2024 10:09:51 -0600 In-Reply-To: <20240330110121.2292510-1-lancelot.six@amd.com> (Lancelot SIX's message of "Sat, 30 Mar 2024 11:01:21 +0000") Message-ID: <87y19x9i9c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rrKEJ-001WEV-2r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:35176 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNmYiFI0l4Wf858LLad9NkdjvE9xB5pUbGyJ8/FnOYZggOO8fBZd3dHvD+nu6lb6Z5cSsZgssmqRKAxa+djlIieKDZgGXFQN4RL4pjKjIC5PMa8Cx7sk K9RLiwNfukemtGiFS14pIejQ7zi0xeZzLgVRBfagQkDqsOwcjU6NkJme9Sxl20hTjLHqTHIFZ/MZyRppFhRa/8s5Y/Eigr/FFIs= X-Spam-Status: No, score=-3015.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot SIX writes: Lancelot> A consequence of this change is that the per_bfd->dwz_file optional Lancelot> object can now remain empty (instead of containing a nullptr), so also Lancelot> this patch also adjusts dwarf2_get_dwz_file to account for this Lancelot> possibility. This effectively reverts the changes to Lancelot> dwarf2_get_dwz_file done by e9b738dfbdc. I'm curious about the motivation for this change. Can dwarf2_get_dwz_file be called when dwarf2_has_info returns false? Tom