From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [RFC 0/9] Attempt to unify Python object's lifecycle
Date: Thu, 20 Feb 2025 12:18:51 -0700 [thread overview]
Message-ID: <87y0y0a0h0.fsf@tromey.com> (raw)
In-Reply-To: <20250127104435.823519-1-jan.vrany@labware.com> (Jan Vrany's message of "Mon, 27 Jan 2025 10:44:26 +0000")
>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:
Jan> My idea was to refactor this housekeeping code into a common class.
Thanks for doing this.
Jan> It could go further (one can convert gdb.Block too and
Jan> gdb.Value and gdb.Value.type and dynamic_type could be
Jan> further simplified too) but I decided to stop here.
I think gdb.Value might be harder as it has some special requirements.
In particular there is code in there to ensure that using the gdb.Value
API doesn't cause too much memory retention -- the "temporary" strategy
that's discussed in another sub-thread. Also the underlying "struct
value" memory management approach is odd.
Jan> All in all, I'm not sure this is the best approach and worth
Jan> it. By this RFC, I'd like to solicit feedback from experienced
Jan> GDB developers on how to move on.
Jan> Basically I see following options:
Jan> 1) Do not change anything in this area (I'm perfectly
Jan> happy with that).
Jan> 2) Intern (memoize) Python objects (where it makes sense)
Jan> but keep the current approach. Basically first four
Jan> commits of this RFC.
Jan> 3) Continue working on this.
I think #3.
I'll send a couple small comments.
Tom
prev parent reply other threads:[~2025-02-20 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 10:44 Jan Vrany
2025-01-27 10:44 ` [RFC 1/9] gdb/python: preserve identity for gdb.Symtab objects Jan Vrany
2025-01-27 10:44 ` [RFC 2/9] gdb/python: preserve identity for gdb.Symbol objects Jan Vrany
2025-02-20 19:22 ` Tom Tromey
2025-01-27 10:44 ` [RFC 3/9] gdb/python: do not hold on gdb.Symtab object from gdb.Symtab_and_line Jan Vrany
2025-01-27 10:44 ` [RFC 4/9] gdb/python: preserve identity for gdb.Type objects Jan Vrany
2025-01-27 10:44 ` [RFC 5/9] gdb/python: introduce gdbpy_registry Jan Vrany
2025-02-20 19:28 ` Tom Tromey
2025-01-27 10:44 ` [RFC 6/9] gdb/python: convert gdb.Symbol to use gdbpy_registry Jan Vrany
2025-01-27 10:44 ` [RFC 7/9] gdb/python: convert gdb.Type " Jan Vrany
2025-01-27 10:44 ` [RFC 8/9] gdb/python: convert gdb.Symtab " Jan Vrany
2025-01-27 10:44 ` [RFC 9/9] gdb/python: convert gdb.Symtab_and_line " Jan Vrany
2025-02-18 11:15 ` [PING] Re: [RFC 0/9] Attempt to unify Python object's lifecycle Jan Vraný
2025-02-19 21:00 ` Simon Marchi
2025-02-20 17:50 ` Jan Vraný
2025-02-20 19:18 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0y0a0h0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox