Re: [PATCH] Fix gstack issues

Keith Seitz
2025-03-28T15:18:14Z

On 3/27/25 11:15 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> With commit fb2ded33c1e519659743047ed7817166545b6d91, I added
> Keith> Fedora's gstack script to gdb. Some issues have arisen since
> Keith> then, and this patch addresses those issues:
>
> Keith> . As Sam James recently noted[1], PKGVERSION and VERSION
> Keith> need to be quoted.
> Keith> . A Fedora user reported the misuse of --readnever, which
> Keith> causes gstack to omit filename and line number information in the
> Keith> backtrace[Red Hat BZ 2354997].
>
> Makes sense to me. Thanks for doing this.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, Tom. I've waited until this morning to push, fearing that
various CIs would detect something, but I think there's been time
for that, and I've pushed the patch.

Keith