From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U9WUExKxUWg/ShIAWB0awg (envelope-from ) for ; Tue, 17 Jun 2025 14:16:50 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kQo9cGta; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FFE11E11C; Tue, 17 Jun 2025 14:16:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D1FFF1E089 for ; Tue, 17 Jun 2025 14:16:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43C603854A97 for ; Tue, 17 Jun 2025 18:16:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43C603854A97 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kQo9cGta Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id EC46B38693D5 for ; Tue, 17 Jun 2025 18:16:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC46B38693D5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC46B38693D5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750184167; cv=none; b=ShWIiX2a3ccO5heV+kiC/uEVgHdf4y272XJV3mpZg6gjKzzfH8CsO582+IYQKxy+hB4IGlWYCvr05y40gF+232xVf7aGkjP2FsgJAOSRMvJ+oLTo+GS/bqUEfUPAopqrUWYQPkUa/q58nKz8wBqt9rXCudz+3uP8KIkfe1BfV24= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750184167; c=relaxed/simple; bh=iiJKR1eqUw6CWdXEMjDX4OMrL+dOCNFdvJ5zvUf0i6A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h+Mw4VyGu6t1QGe5Ikp9aS/ziH3v1NAng2ixIr8RJo/Faea549YSv0utry/jzddKeR7RDIFCO8PGNTbEQKfPMRBpDjbEzr1VFW0oYPLXsctq3FrBzTqzwYGnfdhLAnwgyhveXptVld8tUdorZPUiV7Jc/LPNiEEge1hHVbu7624= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC46B38693D5 Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id RYS4uv4aHVkcRRaqsuKmKX; Tue, 17 Jun 2025 18:16:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RaqsufIS7q3CNRaqsuMije; Tue, 17 Jun 2025 18:16:06 +0000 X-Authority-Analysis: v=2.4 cv=VpfoAP2n c=1 sm=1 tr=0 ts=6851b0e6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6IFa9wvqVegA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=i2gi7bgFWaU8qf9uh9UA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mlugag6Wz3mZgGAhiC0r6rOFNHRRjzBZtpawTVHDZiU=; b=kQo9cGtafQLJCyfkfMSWjV3ps4 odQyr6Ty8THQqfgnTS8Es7HL39XqFI+CGbmBeZoGfPf52ckCkbUW5ZoNNextO4YC2QIkZZt+RQasT T31dQgOYeNme9tzsgzu5O09qD; Received: from 75-166-228-225.hlrn.qwest.net ([75.166.228.225]:42160 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uRaqq-00000002m4B-3eTb; Tue, 17 Jun 2025 12:16:05 -0600 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org, eliz@gnu.org Subject: Re: [PATCH v4 10/11] gdb, gdbarch: Introduce gdbarch method to get the shadow stack pointer. In-Reply-To: <20250617121147.1956686-11-christina.schimpe@intel.com> (Christina Schimpe's message of "Tue, 17 Jun 2025 12:11:46 +0000") References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-11-christina.schimpe@intel.com> X-Attribution: Tom Date: Tue, 17 Jun 2025 12:16:01 -0600 Message-ID: <87y0tqgroe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.228.225 X-Source-L: No X-Exim-ID: 1uRaqq-00000002m4B-3eTb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-228-225.hlrn.qwest.net (bapiya) [75.166.228.225]:42160 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfP/5TtYDI4wCJUito0+Ky6sHFJsCDv46+V7iBGNDWEDpuNZYz5DihX8r+2QlVMSpvAYkM0bo6wbkb0TdhAUCfPuQ9ZB+2Mo+EP0UggwyAMovGDb0YJKx kp00JkH1eEr6eORwK0fSCIg9SkH+1P+c/H7j4ExZuH18mcmZMoO9CCa18yaNJLhabMYg7+Fi+hMM+/tLoF1xRoP6wiNKJbVQ5lY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Christina" == Christina Schimpe writes: Christina> +Method( Christina> + comment=""" Christina> +If possible, return the shadow stack pointer. On some architectures, the Christina> +shadow stack pointer is available even if the feature is disabled. To Christina> +return the shadow stack enablement state configure SHADOW_STACK_ENABLED. Christina> +""", This wasn't super clear to me, but reading patch 11 made me believe that the API is to set shadow_stack_enabled to true if shadow stacks are enabled. Is that correct? If so could you update the comment to say that? You don't have to re-send the whole series just for this change fwiw. thanks, Tom