RE: [PATCH v4 03/11] gdb: Sync up x86-gcc-cpuid.h with cpuid.h from gcc 14 branch.

Schimpe, Christina
2025-06-20T12:40:46Z

Hi Tom,

Thank you for the review!

> If this file is canonically maintained in gcc then this seems totally fine to me.

That's what I'd understand from the comment at the beginning of this file:
/*
* Helper cpuid.h file copied from gcc-14.2.0. Code in gdb should not
* include this directly, but pull in x86-cpuid.h and use that func.
*/

> Approved-By: Tom Tromey <tom@tromey.com>

I'll push the patch together with this series, so I'd wait until it is fully approved.
As currently only this series requires that update.

Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928