From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W0TTD5QgQGmG+gEAWB0awg (envelope-from ) for ; Mon, 15 Dec 2025 09:52:04 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sWQkByMO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2CEBC1E048; Mon, 15 Dec 2025 09:52:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6FD051E048 for ; Mon, 15 Dec 2025 09:52:03 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E07F74BA2E23 for ; Mon, 15 Dec 2025 14:52:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E07F74BA2E23 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sWQkByMO Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 37EF94BA2E04 for ; Mon, 15 Dec 2025 14:51:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37EF94BA2E04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37EF94BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765810296; cv=none; b=vzlKZN8MMm5WHo/X/OLz4EPvAWgc3WC4j8HyNud9URJkHGssfqMUcE41SacoUaRSp2sTJe7WPnCCAoAYkS48lCDZmaZaTEKp5k+lN//8FTKD8vAUS1Q1MoDbph+9zdumguOmc0AoaIVJOwgV/gNEoLHNe4KO8WbVhwPbnnl5VSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765810296; c=relaxed/simple; bh=feZaFRVg2Q5tvDp4WdLKPTy/S8DJ2ONDwDy4II2BPLk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WQ1NtdA41X6FdZDgQPSkGt1iBn35mHPOWmSFBA63J/fZxNZdP/C2yr/72DEpjwoK5RuzH+AVbNPXRZ6W+GM7nGlK8RUZ5V+W8aUMrTyNDRl87qNIdoshRCU5uxc8xBab+ArCpaE77ciXDQx8NfxwLpVFuZHobKvkZhwZcStrgQo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37EF94BA2E04 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id V7GnvzI8MSkcfV9vEv5esW; Mon, 15 Dec 2025 14:51:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id V9tlvJjkoqfpWV9tlv0CVU; Mon, 15 Dec 2025 14:50:05 +0000 X-Authority-Analysis: v=2.4 cv=A55sP7WG c=1 sm=1 tr=0 ts=6940201d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=kjxAffd5F5cubNQUaiAA:9 a=4IKI_MBedZsHOhguCAbN:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=okzQusbjYTqT8UKM14hZnwHxTLzMmK78QCGf0f4UFlk=; b=sWQkByMOupjP7OE5glLmjaONBL qa0/Z6TXnEYS6I0mmBOzkABqGjN9cRsfY3Om2Ch/YxCcRKSygCksUeR/z4X0wP+RPBnd4FiutT2Gh tf0xONpOVztCryiJ7IdcOqO9e; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:49562 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vV9te-00000002f7G-3ke7; Mon, 15 Dec 2025 07:49:58 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org, vries@gcc.gnu.org, tromey@sourceware.org, thiago.bauermann@linaro.org, simon.marchi@efficios.com Subject: Re: [PATCH] Revert "gdb: change blockvector::contains() to handle blockvectors with "holes"" In-Reply-To: <20251208180717.176567-1-jan.vrany@labware.com> (Jan Vrany's message of "Mon, 8 Dec 2025 18:07:17 +0000") References: <20251208180717.176567-1-jan.vrany@labware.com> X-Attribution: Tom Date: Mon, 15 Dec 2025 07:49:49 -0700 Message-ID: <87y0n3zto2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vV9te-00000002f7G-3ke7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:49562 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI2CWJ2oaLC9wau1rXhn2HoBIn4Jq2y6R/89Giomz5Xyhmmtn9wkkOfGToXQGTOus3tDZuQjeaBDKB2wMikECFH+XMjvhsFDUMoi+UHXPRY1Tk9K894W Wr9eJXuCnWVW5nqNrcXUFMpL7vWs9zlMgT9spHWCDXf9ddkhialL1iT3/wjJq/akPu21nDhXwYK/xc3oxZTpmsDGcbW7W7WZwNY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> This reverts commit cc1fc6af4150b19f9c4c70d0463ff498703fb637, since it Jan> causes a number of regressions that seem not to be easily fixable. I hate to revert this since I think it's a better direction for gdb. I guess I think the 'lookup' and 'contains' methods should be equivalent, and neither should ever return the global or static block -- only real code blocks. Jan> The problem lies in existence of "freestanding" code, a code that is Jan> part of a CU but does not have any block associated with it. Consider Jan> following program: ... Jan> When compiled, the foo function has no block of itself: FWIW this is what I would expect. It's just like any other case where a function does not have debug info: no debug info mean no block. Jan> Thiago suggested to use minsymbols to tell whether or a CU contains Jan> given address. I do not think this would work reliably as minsymbols do Jan> no know to which CU they belong. In slightly more complicated case of Jan> interleaved CUs it does not seem to be possible to tell for sure to which Jan> one a given minsymbol belongs. The don't know the CU but at you should still be able to set a breakpoint on them. Anyway, I'd be willing to approve the backout on the basis that it causes some regression. But still I question whether it really makes sense, and if it would be better instead to change the test. Tom