From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wUUyIicafml6eCAAWB0awg (envelope-from ) for ; Sat, 31 Jan 2026 10:05:11 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=B1Gs/2Af; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87DFA1E0E1; Sat, 31 Jan 2026 10:05:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 11F7C1E0BA for ; Sat, 31 Jan 2026 10:05:11 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8340C4BB3BC8 for ; Sat, 31 Jan 2026 15:05:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8340C4BB3BC8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=B1Gs/2Af Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 15F7A4BA9000 for ; Sat, 31 Jan 2026 15:04:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15F7A4BA9000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15F7A4BA9000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769871884; cv=none; b=lP6R1UZSUewyABttoeepuoxQM6w7DF5skxnE/l7r0MEwp9Ws6g9XBctZBU0vytliAuSTpsvug1IDuScQWCam7uQ6ao+wb8wFyRpfA+YwXowQFpvya6RARmpoivULGWh1hHs8JBAdyxbnYT3dJ6dUk107SBvJgA9zwT/LXFQx37Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769871884; c=relaxed/simple; bh=5/3bjooDLUJqFnkmplhIpl33QTHvtuVgdJTlqu7wLlc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Oxc2p11wzezBxpmbo5f3jTlwpokDQV1e+1mwIDs7flLAF363sybbciYok8Z3eCBAJEco1/HT3BwiWfmRjeaOtqop1ZeYzJii2BCCKKGeWu/Ia4EUiXGNICLKAEEEE4oQdesmJV+vT22zDVarJz86SQIQDKMzKH+XaYJ/KmdEqrQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15F7A4BA9000 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id m35XvueitCxrGmCWhvdIUc; Sat, 31 Jan 2026 15:04:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mCWgvPpehHSQMmCWgvQk2h; Sat, 31 Jan 2026 15:04:43 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=697e1a0b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=zmlv0JDLHY_HsV72xtoA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VNR8Hrqx7+wH6V6oCB2xz4uPH+4vvAj1DUXRCtcK2a8=; b=B1Gs/2AfYzdFZerDYwt1U12wsf sSqKlgWHDN2/tQk7OABSzm4XOwju5YTnem01Ms/hR4GVfXkASqf7Xw3aUwChAynKEBOINI0XkJRW1 0mSBlLSU4uNhc9Swr1Vg9Go73; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:59690 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vmCWg-00000003NbT-1vba; Sat, 31 Jan 2026 08:04:42 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/8] Have iterate_over_one_compunit_symtab search included symtabs In-Reply-To: (Simon Marchi's message of "Fri, 30 Jan 2026 17:04:41 -0500") References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-6-8ab183d1911c@tromey.com> X-Attribution: Tom Date: Sat, 31 Jan 2026 08:04:40 -0700 Message-ID: <87y0ldzuuv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vmCWg-00000003NbT-1vba X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (prentzel) [97.122.114.32]:59690 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNMH1XiZfK8l4nKbkJR0OPa0VHuIuV64hHzjGnU+HDxbprKTOo+NgoLJ9srvmtNkzkaQTtc4578Ryaho6X7PGyYLT2W6AOwM1qLz3GUmF2p2aUdX+isX ezqYLLTllm1CUl7/8ae2jucnm4wM/mbVv5JSQnD4ul22nz9DlJ1wSoI7bZM26DtacOn0PlkxXZEvaUVY90i1vLTp4zes1+PLX4k= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> On 2026-01-26 16:33, Tom Tromey wrote: >> @@ -257,10 +262,14 @@ objfile::map_symtabs_matching_filename >> >> auto listener = [&] (compunit_symtab *symtab) >> { >> + /* Skip included compunits. */ >> + if (symtab->user != nullptr) >> + return true; Simon> It would be nice for the comment to say why we skip included compunits: Simon> because iterate_over_one_compunit_symtab searches recursively. I made this change. Tom