From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ycklB7vjhGnoGCoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 13:38:51 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lSeWCXug; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 146C01E08D; Thu, 05 Feb 2026 13:38:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8A751E08D for ; Thu, 05 Feb 2026 13:38:50 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 42A644BB3BB0 for ; Thu, 5 Feb 2026 18:38:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42A644BB3BB0 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lSeWCXug Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 29A614BB3B8E for ; Thu, 5 Feb 2026 18:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29A614BB3B8E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29A614BB3B8E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770316689; cv=none; b=YbFYW1IQNBmdoZHG3A/RqXBev7RoV5/TU3yp+6xnvOdDkt74Xd0Q+3WYIjUBICewDWEOeTxT+/TMOC0sSn2MIS6JXHUM6RKEFHTKi3YLm3TN0zPwW/L4K7uCgQhPbPrjC0AF3xdol9p+XLtk/u695SIfC0JqqharhQbAO+IPp5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770316689; c=relaxed/simple; bh=/9QcBy5KwOqYF2RYUqN7kuKd8lX+Nm52/pNpEnP2C0g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HV5U5QPC8xF4FAR+p6olwhzDqGpQfGAyK5McgMdmRzJqf+4fCDAnuOfHJfpKlApsv260DL5P3zCFq5N00MLv+QPbCQPTrffefBGCCzIbXlJ10nYk2EA7Tmgk2qFDQUnFErMNpPSjrbonj0Oyh5qG8cpmTCYHT/DWvjTfcB3dnCc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29A614BB3B8E Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id o2w7v0EVvKjfoo4EyvhIR7; Thu, 05 Feb 2026 18:38:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id o4ExvS0gHHSQMo4ExvBpKU; Thu, 05 Feb 2026 18:38:07 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=6984e38f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=a5ndaihBTU37eUU0NLAA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ftd8q3QjbqbPRyMGEMgqeZ7LF61O/kcee6qUb9bhL3o=; b=lSeWCXugJZs4hiZNKWOEmxTCTR 1qlXxXbCyB/O4YEF8/dMEV8rJeLbg2CBiAqxNWAWF8T+hoqODqtXVYr6JUhNMvBkGB8bdlJOAGrye 5WXSjYf94THvw9QKQmK1h5RsK; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:36034 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vo4Ex-00000002kR2-064U; Thu, 05 Feb 2026 11:38:07 -0700 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 2/3] gdb/symtab: make compunit_symtab::includes a std::vector In-Reply-To: <20260130025546.322629-2-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 29 Jan 2026 21:55:27 -0500") References: <20260130025546.322629-1-simon.marchi@polymtl.ca> <20260130025546.322629-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 05 Feb 2026 11:38:05 -0700 Message-ID: <87y0l7594i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1vo4Ex-00000002kR2-064U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:36034 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJBly165hpz5gx6PtgBAvVSH8LqtTEqn/RSGM9ImQu017usHDLXgCDDcTJt6Hd3HAVcIg7VQgQe4xFDzy796CK0PCQPV40VY+OD5cVTcty5V2+WyPxoq bqMFdUNiHntX2ciyBSijmUnLUCiTBM7p7qhAsf8sie9snBfYX0H6OtWI61cTM/6McmgwFuxssBhmkxnF1KJ2WDo5LYhUxGkp1h8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> Since compunit_symtab is now a properly constructed and destructed Simon> object, we can use fancy C++ things in it. Change the includes field to Simon> be an std::vector. Simon> Previously, the includes list was NULL-terminated. I went through all Simon> users and I'm pretty sure that none of them rely on it being Simon> NULL-terminated anymore. Looks good. Approved-By: Tom Tromey Tom