From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gc7ILkDCqWn86BYAWB0awg (envelope-from ) for ; Thu, 05 Mar 2026 12:49:52 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iGQ5rLre; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B8B791E0DD; Thu, 05 Mar 2026 12:49:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 81C9C1E089 for ; Thu, 05 Mar 2026 12:49:51 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8D9DF4BA2E1C for ; Thu, 5 Mar 2026 17:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D9DF4BA2E1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iGQ5rLre Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5C7884BA2E10 for ; Thu, 5 Mar 2026 17:49:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C7884BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C7884BA2E10 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772732965; cv=none; b=V9HxYuMY8lLefHGRejf40WJ6JM8gqMG2aEzQ4pnnOTvAQxjY7NKYqdh8maeTD9tiEI5PWL1lDEvQEXuTF/bSN2IapNoPEQowp5thZ+cFUWQq62aWfqnCzvYwBJfcpLmRb3l6l/GOzEXl8paoyPSRgBZ66JcTtmh6oi1qI2uA0Y0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772732965; c=relaxed/simple; bh=85oBNCnBV6CUH/spPS1TAB5Nk3Xj20iE7+jQJm0knXQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c2MGkf9ZrJtdmQaUokTm9A15HeOJof62d0OO6JseEN0fv177Wtt4SGuGYDqe7d76D7GwMr/G/0+f0Wt7nOETCZfrAwssjGBh8KVC+uimIaYPndHBv3zyavfWv4b2D7X/Q/3l/7zzbq+8wgqeAdBEwN//48y35aHAe3iPcZytI40= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C7884BA2E10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772732965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yxICyqR8JZxco5cCZ48KX1vLo079C6Hgt4RitbBq9hI=; b=iGQ5rLreISpN4FVee56PdUxT28ChBY1A0m9EJitL1TUeLtSeQnfR/QeF/YWCsUWgrsspmR UIdrxJeGGocdWuWxoZ4WPGsuBp6RcwdcQeAXIQXs0K4QTnIR/gsVJP/UxDQB2Xbwkam5HS yWehaLr/lS4ybfdPGtukd/TXA4fg+Xg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-TafVuzFdPby8FRooJO9C3g-1; Thu, 05 Mar 2026 12:49:23 -0500 X-MC-Unique: TafVuzFdPby8FRooJO9C3g-1 X-Mimecast-MFC-AGG-ID: TafVuzFdPby8FRooJO9C3g_1772732963 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439a85832c0so4135753f8f.2 for ; Thu, 05 Mar 2026 09:49:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772732962; x=1773337762; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yxICyqR8JZxco5cCZ48KX1vLo079C6Hgt4RitbBq9hI=; b=RwK+tX5/qSPX4lR3MeIljSHlKaG+pPkZT6fVc9xqNe1/bvL44DcmiUxvBeQCLc3nUN 1ZwoUxf8Ry6pF5rO3+CnCH7cnafVlbvJJBmGNX10D4dyBxEhw9doQHk38mO0vO3fxBJz bXwulZbaHXHghCvFA4zqO08iptn4embbLU8L157obf0Qsd/n5H8h7wk4c85WjdQyoVGv IJ5nJs/y3OlLZXYgV+8fSQ6d3cOFy60ZNoTAafeKqbdrs/OI1Wwpqwb9All4XlUpM2Bu 55YTcSCqPIgyiflv0AKU8PgWWZ4XXYAj4e08ZBdACMAORCQJcy/HmbOPP7KuhX0UG33y FQEQ== X-Gm-Message-State: AOJu0YxocnTTNc4pkkuZHQTSHbpf+KuwDE1kT1lJvZ5TcHyHbM3JFEK+ fZKkygdbhTo6oqevzQvxI1l8I+tCQps4Pybz8q39SNiGIummMUZ3o0GaLZcqnYykHZFx8hiIcUk wOK95HMiVk/P7ddWUg5KyO/ncEARl3R8B9CH8qlxNUznjqtn4H+NG/qtwAw5m3tU= X-Gm-Gg: ATEYQzzt2Cs3OT3+JRbfSSOarbts6+pzlm6LQjZYMg3j4ppAtiSrrk7iqDvNPwAAb9z kI9h9syngt54FpkeMxAhsBqQAO6qutD/MAKd1C7wRYLlbgd3Up/uiT1s/Rm6qMaaW8QBttGWSB/ vSy/378DgXt4WsohbSettkPSVLPIIplfu9wV+gIyiolVT8gvmAzcwFNS/a/HOXheqfQBB1M1CUU sJRyVCXV0Jlvcet4vEbWd13ELeraEYapsuUCVGyKDCrEzrkQXOAFzaYKvZuLs5vxiErjom0sxxO fRKiMQmqXZdqjMFgTGPq2AEsQSRe3GBD6MyKlYi71ckdtQI8pInT9NgAqf/0MlV71OMUvmsImcE 3bg+RnUH3kZAVv1Yy X-Received: by 2002:a05:6000:26d1:b0:437:75c1:578e with SMTP id ffacd0b85a97d-439d720e4e8mr1210944f8f.21.1772732962589; Thu, 05 Mar 2026 09:49:22 -0800 (PST) X-Received: by 2002:a05:6000:26d1:b0:437:75c1:578e with SMTP id ffacd0b85a97d-439d720e4e8mr1210906f8f.21.1772732962111; Thu, 05 Mar 2026 09:49:22 -0800 (PST) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b55d15besm39538932f8f.30.2026.03.05.09.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 09:49:21 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/4] Fixes for tail call, until, and FinishBreakpoints In-Reply-To: <878qc6mfmb.fsf@tromey.com> References: <878qc6mfmb.fsf@tromey.com> Date: Thu, 05 Mar 2026 17:49:20 +0000 Message-ID: <87y0k66uan.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BHzdKq-O8JhVOE4yKsiYE9TjBk2whJfp4jDf8yOI65o_1772732963 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> In v2: > Andrew> - Rebased to current upstream HEAD. > > Andrew> - Retested. > > Andrew> I've been looking at places where we use get_frame_pc when we should > Andrew> be using get_frame_address_in_block to handle tail calls correctly. > Andrew> This got me looking at gdb.FinishBreakpoint, and I found a bunch of > Andrew> things that needed fixing. > > Thanks. This all looks good to me. > > Approved-By: Tom Tromey Pushed. Thanks, Andrew