From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e1AjL8fYsmkPHCYAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 11:16:23 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qJIdLHBJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD92A1E08D; Thu, 12 Mar 2026 11:16:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 00D1A1E08D for ; Thu, 12 Mar 2026 11:16:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A6D864BBCDDA for ; Thu, 12 Mar 2026 15:16:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6D864BBCDDA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qJIdLHBJ Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 731AF4BBCDCA for ; Thu, 12 Mar 2026 15:15:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 731AF4BBCDCA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 731AF4BBCDCA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773328550; cv=none; b=P2D2L4YHz4egdHZSNfavImawFI1IwtEvf1QyMitz6/I217lBRQt0SW6R4KHTMMT2Ixk+XkVKwvPSzebx1X+DgddvpTRUeDqdKMeAro+vqP4/0tNq6sJ8vdjeLkcL69tPkk7nmLepjGAZnMxkNsg+Zw8s46tQAIlFtzAc4pgQLIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773328550; c=relaxed/simple; bh=w5R5CFcP4w0ptnsllEqICu6PveSs1Pc4xJp1AXgxbTA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Faj8j5zI/N8mx4RVF+HNQ9q08BFhUPoqagqqFlbyE63IUf6ULRzE4/5QWBu7/Y5dAsm6TWNoQE7KOlkVsRAh8HK/tnO269edUxmiwg5eIXVnpByfe063GN6vCI1elZvmIdwG2TDk711Dxf+yUTDetKLvHgWKAh5yRY1qMQx2Oec= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 731AF4BBCDCA Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id 0ehvw9xLtJ9SZ0hlNwpjZR; Thu, 12 Mar 2026 15:15:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0hl1wVBLh2l0k0hl1w6MuW; Thu, 12 Mar 2026 15:15:27 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=69b2d8a5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=jFwl1VqnVs06N36h6JgA:9 a=4IKI_MBedZsHOhguCAbN:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/3L5JludKn57e2lLjK2pumozcC+t6ksewFzOWCNTJoA=; b=qJIdLHBJAInATTUKP5MMwG1HFO OIpJUYD7RTIcKz+z6NvgT4SF6ycc5z2algbumNGmf5p8iXbXObstWiKNPcnEu0IGfnmg3nyJsKggc Zvng6OuWI1CnCmBHOiVrZNh8m; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:41848 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w0hl0-000000016qB-374Q; Thu, 12 Mar 2026 09:15:26 -0600 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org, tom@tromey.com, Eli Zaretskii Subject: Re: [PATCH v2] gdb/python: add property ranges to gdb.Block object In-Reply-To: <20260312143344.4147036-3-jan.vrany@labware.com> (Jan Vrany's message of "Thu, 12 Mar 2026 14:33:46 +0000") References: <87bjgttecc.fsf@tromey.com> <20260312143344.4147036-3-jan.vrany@labware.com> X-Attribution: Tom Date: Thu, 12 Mar 2026 09:15:25 -0600 Message-ID: <87y0jxrsdu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w0hl0-000000016qB-374Q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:41848 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDrTPEQgNdWY0WING9rR+XGGFu4P2T8rJGd+t1aeygOVsKhTQQyYDBUTUAQEdWaB/dVb+dVS+QcF0YXPmxGSHLsz4xGrxlX+qoc6YcLBnKwdFOzCMSRl nVFOrflVV2wy/l9DfWWgAH/GEDjoayaYQuUPkKHua5S+jJvYJkLXOX1ms37g+DzLdWxOJMfyWdpxFP4b5q9oS8xzfOPRTH5u1oI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> + return Py_BuildValue ("((KK))", block->start (), block->end ()); Jan> + gdbpy_ref<> range_obj (Py_BuildValue ("(KK)", ranges[i].start (), Jan> + ranges[i].end ())); I'm sorry I didn't think of this in the last review, but when using varargs it is up to the caller to ensure that the types are correct. Also, we apparently still support versions of Python that don't guarantee "long long" support. There's some text in python-internal.h about this, look for "HAVE_LONG_LONG". So I think this code needs to use GDB_PY_LLU_ARG and have explicit casts to gdb_py_ulongest. Or maybe be written in some other way. Tom