From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KEh1GuBb0mnFmwgAWB0awg (envelope-from ) for ; Sun, 05 Apr 2026 08:56:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FPxKQ0Yr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4BFDF1E0BC; Sun, 05 Apr 2026 08:56:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 40EF11E04F for ; Sun, 05 Apr 2026 08:55:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 95F4F4BA23DA for ; Sun, 5 Apr 2026 12:55:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95F4F4BA23DA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FPxKQ0Yr Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 023C24BA2E19 for ; Sun, 5 Apr 2026 12:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 023C24BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 023C24BA2E19 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775393732; cv=none; b=Vq1Tj0Biw0PIoPKTjhtS3FcazZZ7GQjFsc29Txmv6pP/64HGCMWwTbeH0ca0fb6cErdR/TKpJaiSFLeY49JhTYsyKxxPYzg/bC0gQx1RkOCB6ev1EEh3wUqz4yiNwIKZRS2sVfUyeaKr+ua9T+l2DcHFS/M8E1KvdLcsXrT6nlg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775393732; c=relaxed/simple; bh=R3yhkxRbE/2iLejZ890PXUA6mx9g77MjTr4uB98cZwc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GWMX7FepNv7ja/pYN+FX9eU6EhfPxIv4sh1vS0M+S6eZFl/6mK+bz/TTJgKoxaEVQovkz5BfwSG2yv1ouxfapT+7a2F+VViKLyXrpz8NCcdfbV2p4mLmILsgZD+xl4NCp8yOmjkhNfso2ZiCIz8DkWTxWwlNaIi/sdXc/W9s1pA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 023C24BA2E19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775393731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FBOOzj5VMu6cuG0CC2jWpu3bHbM3gj68aK8YdjOtkIk=; b=FPxKQ0Yr9e9KJ7bx/kwbyyroQkGGVMgv7XkpgKkj82oNph0PvYX8jA50APN0aUm0qhvh/N Ls/zZMqAlflQeqanSQ7r8TCqtuCavTEJDPAy40H34Qkzhx6em6xO0r7fL9D6AfwSKjIbB6 FUehjkMm8szWAQ0IurAbNI359i4FwdY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-91iODus6PxiI_QBOSljeRw-1; Sun, 05 Apr 2026 08:55:30 -0400 X-MC-Unique: 91iODus6PxiI_QBOSljeRw-1 X-Mimecast-MFC-AGG-ID: 91iODus6PxiI_QBOSljeRw_1775393729 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d03bad787so3305103f8f.1 for ; Sun, 05 Apr 2026 05:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775393729; x=1775998529; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FBOOzj5VMu6cuG0CC2jWpu3bHbM3gj68aK8YdjOtkIk=; b=HYVjFOlMdY9c2Wmf1f1H8XRkZkcn1vjfQPZMr7ZXy4l5uuymI4SIqSCg+3yrtqRfj6 cdbsgXqVAKrHs000mKxbDApUw5K/T/b39XkHwmW9EFOpVsE4eBgPyfrw4gpdLk1XXm1R NeJ33M/SxiqsJ3JCqiCNgPbsG5Dj71DKG8htV10ZBN8BOLXTaAubGNc0GJf/+jioWlv+ sWF+Sa5EzPFL5G7tYvVUuDvpxtLR1zPDIYCOSMVX7knzmm7VASWG3JWtqbKY9b9XlABU glM3KVJQoRF4GKsFS6jTPhLNFiI1Rqv20PfcvKh7rrz3KyWPzbMBLeVHqKhcNK099aR5 gzIA== X-Forwarded-Encrypted: i=1; AJvYcCX6h24wmOo3HKNLb74c1lClqzlCYqeBoWPbJ0mH3eQ2xh3YSKUDGumPYQrJaPj0CwjRs100w2r4IJ4ikQ==@sourceware.org X-Gm-Message-State: AOJu0YxmN6nFYIi2HkVKDRmgRZtxa9wmFrcV/RXGcm2bGCtctFoz/Sh4 ghO2Ob1EdYVKIabAwlXhUJNF6gXkQM30Z6FZtp9+5mHv3QMLOBkk+r794JAqKSGvRdAJUrDSkaf 3wXJrfALkEf0cegNngwUoC23XwrRllZB0FfaP0i5lm0h8iNOAMiSyrikXhoe+IMw= X-Gm-Gg: AeBDieto7WqU5TM4Y5mBL8m0U7BMN+dJugajiTdNK4/ROlUSLgiNyWthvttmOIV2rv5 YQ7YryDmWYn4j+rmI09gucQsK6EHa+9sSYxivnISGPzkzV8VA9fhOANMxnb7SE7YCathQ71dpn/ RquZDnC/A4T8CFbxDH8ZV/+h0r+GKK2W5Po1t2zuud4ljVbgH20fgatrOLcflEm7DaU5dsqUyKc ZibNRIBLuovKXO01QcyuVs7ub7oT8JV5Y+jm71Uv8BZyGxABwWy+meeencssfahbzLBWdkBO85a og5u8AQL41TJOHz+1rMeOb6AIv7RXx60aO1jvJiFKd7g3RU6/BTcdblVra2ZD4qjzZU2vDVgoX3 LTiMOeLogXWcibp9K X-Received: by 2002:a05:6000:310f:b0:43b:509c:4275 with SMTP id ffacd0b85a97d-43d29277072mr14892486f8f.16.1775393729049; Sun, 05 Apr 2026 05:55:29 -0700 (PDT) X-Received: by 2002:a05:6000:310f:b0:43b:509c:4275 with SMTP id ffacd0b85a97d-43d29277072mr14892460f8f.16.1775393728567; Sun, 05 Apr 2026 05:55:28 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c637asm30454602f8f.14.2026.04.05.05.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 05:55:28 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 0/4] Add more styling of error messages In-Reply-To: <20260405-more-error-style-v1-0-6c04da718875@tromey.com> References: <20260405-more-error-style-v1-0-6c04da718875@tromey.com> Date: Sun, 05 Apr 2026 13:55:27 +0100 Message-ID: <87y0j14lds.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: skV_SqYmXSFVbS1rzgIcPfKShHh-P9SfZpv11-zsFZs_1775393729 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > This series adds more styling of error messages. I searched through > error messages for common patterns to find the places to edit. So, I > have probably missed a few. > > I fixed up some quoting in the "command style" patch, but in other > spots I left it alone. > > I didn't write new tests. I don't know how anyone else feels about > this but I tend to think that testing the styling of error messages is > overkill. > > There are still more styles that could be applied, for instance line > numbers. Also I discovered that the previous fix to allow error() to > be styled did not apply to throw_error et al. So, some more work > there is needed. > > Regression tested on x86-64 Fedora 40. I've not checked every single change, but I looked through a random sampling, and it all looks good. Nice to see more styling being added. Approved-By: Andrew Burgess Thanks, Andrew > > Signed-off-by: Tom Tromey > --- > Tom Tromey (4): > Add command styling to error messages > Add filename styling to error messages > Add variable styling to error messages > Add function styling to error messages > > gdb/ada-exp.y | 8 +++-- > gdb/ada-tasks.c | 10 ++++--- > gdb/amd64-linux-tdep.c | 5 ++-- > gdb/breakpoint.c | 50 +++++++++++++++++++++----------- > gdb/c-exp.y | 10 +++++-- > gdb/cli/cli-cmds.c | 35 ++++++++++++++-------- > gdb/cli/cli-dump.c | 21 +++++++++----- > gdb/cli/cli-script.c | 33 ++++++++++++++------- > gdb/cli/cli-utils.c | 18 ++++++++---- > gdb/coffread.c | 19 ++++++++---- > gdb/compile/compile-object-load.c | 36 +++++++++++++---------- > gdb/compile/compile.c | 6 ++-- > gdb/corelow.c | 10 ++++--- > gdb/ctfread.c | 16 ++++++---- > gdb/d-exp.y | 4 ++- > gdb/dwarf2/ada-imported.c | 6 ++-- > gdb/dwarf2/dwz.c | 9 +++--- > gdb/eval.c | 9 ++++-- > gdb/exec.c | 14 +++++---- > gdb/findvar.c | 4 ++- > gdb/gcore.c | 9 ++++-- > gdb/gdb_bfd.c | 12 +++++--- > gdb/guile/guile.c | 4 ++- > gdb/inf-child.c | 3 +- > gdb/infcall.c | 58 ++++++++++++++++++++++--------------- > gdb/infcmd.c | 6 ++-- > gdb/linespec.c | 1 + > gdb/linux-nat.c | 4 ++- > gdb/maint.c | 3 +- > gdb/parse.c | 4 ++- > gdb/printcmd.c | 11 +++---- > gdb/python/python.c | 3 +- > gdb/record-btrace.c | 4 ++- > gdb/record-full.c | 25 +++++++++------- > gdb/record.c | 6 ++-- > gdb/remote-fileio.c | 11 +++++-- > gdb/remote.c | 20 +++++++++---- > gdb/rust-lang.c | 6 ++-- > gdb/skip.c | 5 ++-- > gdb/solib-aix.c | 16 ++++++---- > gdb/solib-darwin.c | 7 +++-- > gdb/solib.c | 14 +++++---- > gdb/symfile-mem.c | 16 +++++++--- > gdb/symfile.c | 30 +++++++++++-------- > gdb/symmisc.c | 3 +- > gdb/symtab.c | 3 +- > gdb/target.c | 41 +++++++++++++++++--------- > gdb/testsuite/gdb.base/commands.exp | 3 +- > gdb/testsuite/gdb.base/default.exp | 2 +- > gdb/tracectf.c | 16 ++++++---- > gdb/tracefile-tfile.c | 6 ++-- > gdb/utils.c | 4 ++- > gdb/valops.c | 29 +++++++++++-------- > gdb/xcoffread.c | 6 ++-- > gdb/xml-support.c | 5 +++- > 55 files changed, 465 insertions(+), 254 deletions(-) > --- > base-commit: 2ec5e53d96e3def7ee11966fd07ae215be84515a > change-id: 20260405-more-error-style-0c3bb6e1b9ad > > Best regards, > -- > Tom Tromey