Re: GDB 18.0.90 available for testing

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Thu, 06 Aug 2026 19:12:40 +0100
>> From: Andrew Burgess <aburgess@redhat.com>
>> 
>> Hello,
>> 
>> I have just finished creating the gdb-18.0.90 pre-release.
>> It is available for download at the following location:
>> 
>>     https://sourceware.org/pub/gdb/snapshots/branch/gdb-18.0.90.tar.xz
>> 
>> A gzip'ed version is also available: gdb-18.0.90.tar.gz.
>> 
>> Please give it a test if you can and report any problems you might find.
>
> I've built this pretest for native MinGW debugging on MS-Windows, and
> encountered the following minor issues:
>
> 2. Recompilation of libsframe/sframe.c emits warnings:
>
>        CC       libsframe_la-sframe.lo
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:127: warning: "PACKAGE" redefined
>        127 | #define PACKAGE "libctf"
> 	   |
>      In file included from sframe.c:20:
>      config.h:66: note: this is the location of the previous definition
> 	66 | #define PACKAGE "libsframe"
> 	   |
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:133: warning: "PACKAGE_NAME" redefined
>        133 | #define PACKAGE_NAME "libctf"
> 	   |
>      In file included from sframe.c:20:
>      config.h:72: note: this is the location of the previous definition
> 	72 | #define PACKAGE_NAME "libsframe"
> 	   |
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:136: warning: "PACKAGE_STRING" redefined
>        136 | #define PACKAGE_STRING "libctf 1.2.0"
> 	   |
>      In file included from sframe.c:20:
>      config.h:75: note: this is the location of the previous definition
> 	75 | #define PACKAGE_STRING "libsframe BFD_VERSION"
> 	   |
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:139: warning: "PACKAGE_TARNAME" redefined
>        139 | #define PACKAGE_TARNAME "libctf"
> 	   |
>      In file included from sframe.c:20:
>      config.h:78: note: this is the location of the previous definition
> 	78 | #define PACKAGE_TARNAME "libsframe"
> 	   |
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:145: warning: "PACKAGE_VERSION" redefined
>        145 | #define PACKAGE_VERSION "1.2.0"
> 	   |
>      In file included from sframe.c:20:
>      config.h:84: note: this is the location of the previous definition
> 	84 | #define PACKAGE_VERSION "BFD_VERSION"
> 	   |
>      In file included from ./../libctf/swap.h:23,
> 		      from sframe.c:27:
>      ./../libctf/config.h:173: warning: "VERSION" redefined
>        173 | #define VERSION "1.2.0"
> 	   |
>      In file included from sframe.c:20:
>      config.h:112: note: this is the location of the previous definition
>        112 | #define VERSION "BFD_VERSION"
> 	   |
>
> This is because sframe.c includes libctf/swap.h, which includes
> libctf/config.h, which defines these macros for libctf, not for
> libsframe.  Strangely, the initial compilation didn't produce these
> warnings, but when I needed to recompile sframe.c later, it did.

I tracked this down to an issue with an '#include "config.h"' in
libctf/swap.h.  This issue only becomes a problem when doing a build in
the source tree, and due to the way config.h is generated by autotools,
will only be an issue on the second (or later) build in a tree.

As far as I can tell this issue has existed since GDB 13, but it will
only be noticable if a rebuild of sframe.c is triggered.

I sent a possible fix for this to the binutils list here:

  https://inbox.sourceware.org/binutils/27dfa5e4c684cfdd773e207e8022234109eb1b91.1786465076.git.aburgess@redhat.com

If this is accepted then we can back port this to the GDB 18 branch, but
given this issue has not caused significant problems for the recent
releases, I wouldn't plan to block the release for this fix.

Thanks,
Andrew