From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mrKhMr8qg2pUMC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:37:35 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bmoaM/5/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BD4221E0A3; Mon, 17 Aug 2026 11:37:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6E79F1E033 for ; Mon, 17 Aug 2026 11:37:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 86FB64BA9014 for ; Mon, 17 Aug 2026 15:37:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86FB64BA9014 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bmoaM/5/ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id D84FD4BA7986 for ; Mon, 17 Aug 2026 15:36:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D84FD4BA7986 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D84FD4BA7986 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981015; cv=none; b=hAkGuCheCqFz23m/TbuBVMzj05BARVU85I+3gzMK0EnRBk7Ypall/NtjLLcZo/65K3jjVpAXkBxYPg4BoDGjh3xnm4WO8mgksDZLVOir5VSFmSKrHZFowVDV8pn9zpWfc2w0XzEsAJ+UoqE2agX/n2uKEexILs3A+vNaqHqboBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981015; c=relaxed/simple; bh=bYiBoYWgxwqRna77vjKeZ4Bu+s+MC1oc7ABgCs5OEPw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=a4CjM/57p/a9ybkfTuc6xiXj3wqRw+DiJYstktuS1JQDEfmg3oX0s5uXfGo/pqHWuHbGoPaud+74IxAG1XyrtxR7xWAIDEgF+UaetH/tmTShTj3U3mrBwI9zIuIN94DZRjgk+uyQJSMF3bF7xef127NlsAa8RZyHGVQgE/lTMFY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bmoaM/5/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D84FD4BA7986 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786981014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F+7ox00bHi+gtP0EU03ViO7HlImoKPW2c5P+Fam9c6g=; b=bmoaM/5/+ldJLBARDmqo+68eAT5YHCnnzw7BLgoCTCz1agQj7RI9hte4/MPoN2wjDw522r PR/9ycAkNZdpIqrOLB953miLJFlA6c530StuUxl67CjSItseMg7jXWAube31dYgJZ6n3EX 5nBYVd2gze4EL+iQutTTTiAobLQqT2o= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-VbKdc6RlNmKmvcjcZXA4Bg-1; Mon, 17 Aug 2026 11:36:52 -0400 X-MC-Unique: VbKdc6RlNmKmvcjcZXA4Bg-1 X-Mimecast-MFC-AGG-ID: VbKdc6RlNmKmvcjcZXA4Bg_1786981011 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47485fde05aso2074147f8f.0 for ; Mon, 17 Aug 2026 08:36:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786981011; x=1787585811; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=F+7ox00bHi+gtP0EU03ViO7HlImoKPW2c5P+Fam9c6g=; b=pZpWxhVsJWASou91pjm38xphNajKFPlRoZmR2cqVEEi+VWPM+6Xkh1jeI8lilViT4R zikdg9ck5aPxPgxghm7GyhkEOf5B7FoF0CvfI5MS4V6dGlkPkBqdVeC1hpYvoLc2mm1k gozLdL/ovcpW95OHp6VPjCATff5owYpMUnHGU3DxDpCxcpQrdZeZg2djyTQGVI/t/JgJ h3egLfcFVbDz/ICCF6YstI1u3KMX/sFNFADwzttEDvxk6089gDB/3fQ0I8lHMU9n9I2z 6h1drirOBjEkpsktQikE5hutIfDzegFswEOa+77PvYtVtFObqAVG5N4/QgszgdEPFp/B jilA== X-Forwarded-Encrypted: i=1; AHgh+RrR7L1CSJ3dT5npARPec7nViaTUB0TZXPiQrAVMdrU6FZ1JKx0y77lI2fieUP83kO9E0IYg48Ne3q5/4g==@sourceware.org X-Gm-Message-State: AOJu0YzBkBOubgXR4/CD37z2jROGdDJbFjbQsij1zyPsX7nsqK/VRLmq nCzQWtE0zh52pX3SpRck0s3RDA86sT42mnz8bzgr2RmmRQpeTQZvOFoLV//LSRPmgE0wI+Q5Q4F 58FfBbywGyZtb9P5Pun8NN0YQ4VMTg4EErRKb0QAdCvlv2eminFXM7KJgNGYoegeidaijcO4= X-Gm-Gg: AR+sD11Nzyqu+m6rp1NwYUjAzlTn5ems2NO3qJP1sd6rt25cbndp59pL5pRmvxvqcT9 3taT8THFmXm6rkHCmsYrE2/LvSyN+WZzh/0USqnm5u8Xmi7F2aOKoBw8hUVrFFuTaBPYpCPF3H6 iDJk7boE8kept1QXayajFhKNsTBjdt7mDq/9LJy+ubYTCUw8y7QuxHb4m6Md+UBwnucaAsMs5mW am8URndB4DXHWmyOAQA0OpdChFxfyWzkGKO2J389mqLsHksK4KlilGwgr2oq/a9EcZHYds9qvZB BBqtfDeE+A8oFKZs+GVlSXrMW7mFmEX9oPVOWYIPqMLTakUVom6u8UPOICFKd4ayjDm8Yna1Qe5 6gmLyln/UNumVeORofi4= X-Received: by 2002:adf:e002:0:10b0:482:a610:7a27 with SMTP id ffacd0b85a97d-482a6107a55mr4871463f8f.20.1786981011410; Mon, 17 Aug 2026 08:36:51 -0700 (PDT) X-Received: by 2002:adf:e002:0:10b0:482:a610:7a27 with SMTP id ffacd0b85a97d-482a6107a55mr4871399f8f.20.1786981010953; Mon, 17 Aug 2026 08:36:50 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b816f7sm4619003f8f.34.2026.08.17.08.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:36:50 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 04/13] sim/ppc: make defines.h sed command portable In-Reply-To: <20260817151646.152571-5-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-5-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 16:36:49 +0100 Message-ID: <87y0e43gj2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vPGE4TziT5EdzLYpLDthen3oLCw7ggtNwjprOaIE3Wc_1786981011 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, whose sed is the BSD one, I get: > > GEN ppc/stamp-defines > sed: 1: "/^#define HAVE_.*1$/{ s ...": extra characters at the end of p command > make[1]: *** [ppc/stamp-defines] Error 1 > > BSD sed apparently does not accept a `}' directly after another command, > it needs a separating semicolon. Add one after the `p'. GNU sed > accepts both forms, and produces the same output either way. Approved-By: Andrew Burgess Thanks, Andrew > > Re-generate sim/Makefile.in. > > Change-Id: I0709ad7b0051e08299f2576113b549aba9fc703f > --- > sim/Makefile.in | 2 +- > sim/ppc/local.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sim/Makefile.in b/sim/Makefile.in > index 1f9bbfec03f1..2a23b5c2eaa9 100644 > --- a/sim/Makefile.in > +++ b/sim/Makefile.in > @@ -5722,7 +5722,7 @@ testsuite/common/bits64m63.c: testsuite/common/bits-gen$(EXEEXT) testsuite/commo > > @SIM_ENABLE_ARCH_ppc_TRUE@ppc/defines.h: ppc/stamp-defines ; @true > @SIM_ENABLE_ARCH_ppc_TRUE@ppc/stamp-defines: config.h Makefile > -@SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p }' < config.h > ppc/defines.hin > +@SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p; }' < config.h > ppc/defines.hin > @SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_at)$(SHELL) $(srcroot)/move-if-change ppc/defines.hin ppc/defines.h > @SIM_ENABLE_ARCH_ppc_TRUE@ $(AM_V_at)touch $@ > > diff --git a/sim/ppc/local.mk b/sim/ppc/local.mk > index f9f134abe3c9..9aca96465acd 100644 > --- a/sim/ppc/local.mk > +++ b/sim/ppc/local.mk > @@ -80,7 +80,7 @@ noinst_PROGRAMS += %D%/run > > %D%/defines.h: %D%/stamp-defines ; @true > %D%/stamp-defines: config.h Makefile > - $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p }' < config.h > %D%/defines.hin > + $(AM_V_GEN)$(SED) -n -e '/^#define HAVE_.*1$$/{ s/ 1$$/",/; s/.* HAVE_/"HAVE_/; p; }' < config.h > %D%/defines.hin > $(AM_V_at)$(SHELL) $(srcroot)/move-if-change %D%/defines.hin %D%/defines.h > $(AM_V_at)touch $@ > > -- > 2.55.0