Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Update gdb.ada/unchecked_union.exp for gnat-llvm
Date: Tue, 18 Aug 2026 11:35:02 -0600	[thread overview]
Message-ID: <87y0e3tjqx.fsf@tromey.com> (raw)
In-Reply-To: <87o6ez1tzq.fsf@redhat.com> (Andrew Burgess's message of "Tue, 18 Aug 2026 13:41:13 +0100")

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Could I suggest a rewording:

I made this change.

Andrew> I do wish the quotemeta system didn't do hungry white space matching by
Andrew> default, especially as it's use expands through the testsuite.  But
Andrew> that's out of scope for this patch, which looks good.

Better to fix things early than late.

I did it this way mainly because that's how the AdaCore one works; but
the rationale for that is it makes the test suite less sensitive to
word-wrap decisions.

We could perhaps handle this a different way though, like a special "@{ }"
or something.

Also I suppose maybe in practice the word wrap issue may not come up all
that much.  I'm not sure.

Tom

      reply	other threads:[~2026-08-18 17:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 19:54 Tom Tromey
2026-08-18 12:41 ` Andrew Burgess
2026-08-18 17:35   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0e3tjqx.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox