From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34060-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 20047 invoked by alias); 26 Jun 2004 04:56:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 20005 invoked from network); 26 Jun 2004 04:56:32 -0000
Received: from unknown (HELO mail.codesourcery.com) (65.74.133.5)
  by sourceware.org with SMTP; 26 Jun 2004 04:56:32 -0000
Received: (qmail 4211 invoked from network); 26 Jun 2004 04:56:32 -0000
Received: from taltos.codesourcery.com (zack@66.92.218.83)
  by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 26 Jun 2004 04:56:32 -0000
Received: by taltos.codesourcery.com (sSMTP sendmail emulation); Fri, 25 Jun 2004 21:56:31 -0700
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Bernardo Innocenti <bernie@develer.com>,  Ian Lance Taylor
 <ian@wasabisystems.com>,  GCC Patches <gcc-patches@gcc.gnu.org>, 
 gdb-patches@sources.redhat.com,  binutils@sources.redhat.com,  DJ Delorie
 <dj@redhat.com>
Subject: Re: [top-level] C++-friendly allocators for libiberty
References: <40DCC86A.4010306@develer.com> <m3659fm87e.fsf@gossamer.airs.com>
	<40DCD0EE.9010208@develer.com> <m31xk3m577.fsf@gossamer.airs.com>
	<40DCE1C8.4020202@develer.com>
	<orr7s3rnh7.fsf@livre.redhat.lsd.ic.unicamp.br>
From: Zack Weinberg <zack@codesourcery.com>
Date: Sat, 26 Jun 2004 04:56:00 -0000
In-Reply-To: <orr7s3rnh7.fsf@livre.redhat.lsd.ic.unicamp.br> (Alexandre
	Oliva's message of "26 Jun 2004 00:45:40 -0300")
Message-ID: <87wu1u7w8w.fsf@taltos.codesourcery.com>
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-06/txt/msg00552.txt.bz2

Alexandre Oliva <aoliva@redhat.com> writes:

>> +#define xcnewvec(T, N)		(T *) xcalloc (N, sizeof (T))
>> +#define xresize(T, P, S)	(T *) xrealloc (P, S)
>> +#define xresizevec(T, P, N)	(T *) xrealloc (P, sizeof (T) * (N))
>> +#define xobnew(O, T)		(T *) obstack_alloc (O, sizeof (T))
>
> You're missing parentheses around N, P (twice), S and O.

They're not actually necessary in this context.

zw