From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13468 invoked by alias); 21 Feb 2012 19:11:08 -0000 Received: (qmail 13455 invoked by uid 22791); 21 Feb 2012 19:11:07 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Feb 2012 19:10:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1LJAU4x029944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Feb 2012 14:10:53 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1LI5E46032691; Tue, 21 Feb 2012 13:05:14 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1LI5CtO014808; Tue, 21 Feb 2012 13:05:13 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: testsuite: prefix handling References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> <87pqdd9pjs.fsf@fleche.redhat.com> <4F3EBEAC.1070805@redhat.com> <87k43l87vb.fsf@fleche.redhat.com> <4F43B6A5.3010900@redhat.com> Date: Tue, 21 Feb 2012 19:17:00 -0000 In-Reply-To: <4F43B6A5.3010900@redhat.com> (Pedro Alves's message of "Tue, 21 Feb 2012 15:22:13 +0000") Message-ID: <87wr7gt63r.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00444.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> if {$r == 0} { Pedro> I think checking for $r == 1 (TCL_ERROR) explicitly is more correct. I agree. My Tcl is rusty :) Pedro> Only a few tests weren't converted to use with_test_prefix by this Pedro> patch. Those are ones that I found that: Pedro> - would require a large reindent Pedro> - or with_test_prefix wasn't a 1-1 replacement I don't mind large reindents in a situation like this. I think the resulting code would be better. It is up to you, though; I also don't mind the status quo. Pedro> WDYT? Pedro> -proc altivec_abi_tests { extra_flags force_abi } { Pedro> +proc altivec_abi_tests { prefix extra_flags force_abi } { with_test_prefix $prefix { [...] Pedro> +}} I think newlines and reindentation would result in prettier code. The size of the diff is secondary to me; just because we'll have to read and edit the result, not the patch. Pedro> - altivec_abi_tests "additional_flags=-maltivec" "auto" Pedro> + altivec_abi_tests " default ABI, auto:" "additional_flags=-maltivec" "auto" It would be both prettier and better encapsulation if with_test_prefix supplied the space. Pedro> +# Test files shall make sure all the test result lines in gdb.sum are Pedro> +# unique in a test run, so that comparing the gdb.sum files of two Pedro> +# test runs gives correct results. Test files that exercise Pedro> +# variations of the same tests more than once, shall prefix the Pedro> +# different test invocations with different identifying strings in Pedro> +# order to make them unique. [...] I love the comment. Tom