From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16900 invoked by alias); 24 Apr 2012 17:40:02 -0000 Received: (qmail 16791 invoked by uid 22791); 24 Apr 2012 17:40:00 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 17:39:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHdlKI030469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 13:39:47 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3OHdktJ014304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 24 Apr 2012 13:39:46 -0400 From: Tom Tromey To: Pedro Alves Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag) References: <4F968B4D.3050209@redhat.com> Date: Tue, 24 Apr 2012 17:42:00 -0000 In-Reply-To: <4F968B4D.3050209@redhat.com> (Pedro Alves's message of "Tue, 24 Apr 2012 12:15:25 +0100") Message-ID: <87wr55do66.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00810.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> There's no need to commit all this in one go. Once you split, Pedro> some of the resulting patches will be dead obvious, and will end up Pedro> reviewed (if even necessary) and checked in quickly, and thus you end up Pedro> making progress faster that way. It seems to me that a variable that is declared but not initialized and not used is always going to be obviously dead. I'd be comfortable with pre-approving all such removals; leaving review for the patches to the generators and initialized variables. Tom