From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10473 invoked by alias); 21 Feb 2013 21:06:50 -0000 Received: (qmail 10460 invoked by uid 22791); 21 Feb 2013 21:06:49 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Feb 2013 21:06:38 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1LL6aaJ009577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Feb 2013 16:06:36 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1LL6YL4007356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 21 Feb 2013 16:06:34 -0500 From: Tom Tromey To: "Maciej W. Rozycki" Cc: Richard Sandiford , Catherine Moore , , Subject: Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support References: Date: Thu, 21 Feb 2013 21:06:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Tue, 19 Feb 2013 20:44:10 +0000") Message-ID: <87wqu19y1x.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00573.txt.bz2 >>>>> "Maciej" == Maciej W Rozycki writes: Maciej> + NOTE: macro-20130129: The MIPS backend uses the 8 LSBs of I prefer not putting usernames and dates into the comments. That is readily found in the history -- but also more commonly just not needed. Maciej> if (type != ST_SYNTHETIC) Maciej> elf_sym = (elf_symbol_type *) sym; Maciej> - else Maciej> + else if (((sym->udata.i | 0xff) ^ 0xff) != 0) Maciej> elf_sym = (elf_symbol_type *) sym->udata.p; Maciej> + else Maciej> + elf_sym = NULL; This seems iffy to me. I suppose what gives me pause is the possibility that this condition will trigger on some other port that does something odd in BFD. I'm not really an expert here -- I'd appreciate other comments. Maciej> -/* In SVR4, we recognize a trampoline by it's section name. Maciej> - That is, if the pc is in a section named ".plt" then we are in Maciej> - a trampoline. */ Maciej> +/* In SVR4, we recognize a trampoline by it's section name. That is, Maciej> + if the pc is in a section named ".plt" then we are in a trampoline. Maciej> + We let targets request an alternative name, this is currently used Maciej> + by the MIPS backend to handle the SVR4 lazy resolution stubs that Maciej> + binutils put into ".MIPS.stubs" instead. */ IMO comments like this tend to get stale over time. It is better, I think, to describe the function's interface and purpose, and leave it to future developers to grep for uses of it, should they need to know. Tom