From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24835 invoked by alias); 19 Apr 2013 14:43:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24824 invoked by uid 89); 19 Apr 2013 14:43:30 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 14:43:30 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEhTYA019797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 10:43:29 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEhRnn001915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 10:43:28 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 26/28] fix refcount bug in typy_fields References: <87ehe638ww.fsf@fleche.redhat.com> Date: Fri, 19 Apr 2013 17:50:00 -0000 In-Reply-To: <87ehe638ww.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 19 Apr 2013 08:13:51 -0600") Message-ID: <87wqrywpgw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00610.txt.bz2 The checker found a bug in typy_fields -- we leaked a reference in one path. * python/py-type.c (typy_fields): Unconditionally decref 'r'. --- gdb/python/py-type.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c index 63629fe..337e307 100644 --- a/gdb/python/py-type.c +++ b/gdb/python/py-type.c @@ -379,10 +379,7 @@ typy_fields (PyObject *self, PyObject *args) return NULL; rl = Py_BuildValue ("[O]", r); - if (rl == NULL) - { - Py_DECREF (r); - } + Py_DECREF (r); return rl; } -- 1.8.1.4