From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10869 invoked by alias); 24 Jul 2013 14:04:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10858 invoked by uid 89); 24 Jul 2013 14:04:00 -0000 X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Jul 2013 14:03:59 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6OE3or5027462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Jul 2013 10:03:50 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6OE3m9K020156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Jul 2013 10:03:49 -0400 From: Tom Tromey To: "Maciej W. Rozycki" Cc: Yao Qi , Subject: Re: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver. References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1372475427-24862-1-git-send-email-yao@codesourcery.com> <1372475427-24862-2-git-send-email-yao@codesourcery.com> Date: Wed, 24 Jul 2013 14:04:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Wed, 24 Jul 2013 01:25:58 +0100") Message-ID: <87wqogvyuz.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00567.txt.bz2 >>>>> "Maciej" == Maciej W Rozycki writes: Maciej> On Sat, 29 Jun 2013, Yao Qi wrote: >> 'enum target_hw_bp_type' has been used in both GDB and GDBserver. It >> will be used in MIPS hardware watchpoint support too. This patch >> is to share 'enum target_hw_bp_type' in common/break-common.h. Maciej> FWIW this patch looks reasonable to me, though I can't approve Maciej> or reject a generic change like this. I can see Maciej> gdb/gdbserver/linux-aarch64-low.c has a similar Maciej> target_point_type enum. It might be a good idea to unify them Maciej> all. This patch is ok. Tom