From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23012 invoked by alias); 18 Dec 2013 22:06:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23002 invoked by uid 89); 18 Dec 2013 22:06:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 22:06:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIM6iJn009305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 17:06:44 -0500 Received: from barimba (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBIM6hLb022507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 18 Dec 2013 17:06:44 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 3/9] add target method delegation References: <1382464769-2465-1-git-send-email-tromey@redhat.com> <1382464769-2465-4-git-send-email-tromey@redhat.com> <526E8B54.8040104@redhat.com> <87eh75cmig.fsf@fleche.redhat.com> <87a9htcme3.fsf@fleche.redhat.com> <87habz7q6g.fsf@fleche.redhat.com> <527D1A84.9040106@redhat.com> <87lhzr11wz.fsf@fleche.redhat.com> <87a9g623cw.fsf@fleche.redhat.com> <871u1gz9q2.fsf@fleche.redhat.com> <52AEFB0A.3090104@redhat.com> <87r49cpk54.fsf@fleche.redhat.com> <52B078FA.8040004@redhat.com> <87d2kum2ri.fsf@fleche.redhat.com> Date: Wed, 18 Dec 2013 22:06:00 -0000 In-Reply-To: <87d2kum2ri.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 18 Dec 2013 11:29:21 -0700") Message-ID: <87wqj1lsp8.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-12/txt/msg00727.txt.bz2 Pedro> Yeah, not sure either... squash a few; post only the non-trivial Pedro> ones as email; post all of them at once anyway; split in 4 or Pedro> 5 batches. Whatever really is fine with me. In case you want to see my progress, I've pushed the current branch to my gitorious repository: git@gitorious.org:binutils-gdb/gdb.git The branch is "target-cleanup". I've built the branch but barely tested it. I'm sure it breaks in some configurations -- the fixes are trivial but I did have to do a number of them as my refactoring script, while fun, could not perfectly fix everything. Aside from a few patches at the beginning of the series I think it's all split and ordered pretty much as I'd like it to be. I converted all the easy target methods to the new inheritance scheme. This works out to be nearly all of them. There are a few more that aren't too bad to convert (actually, looking again now I see I missed a few more easy ones), and then a handful of tricky ones. It's over the 200 patch mark... not sure I want to write those ChangeLogs (my refactoring script only did the first 100 or so for me...) or even re-read them all for sanity. I hope you will agree that the result is much cleaner. It's simpler to explain and understand; and it is obvious which model one ought to choose when adding new target methods. It's also a good setup for the multi-target work. Tom