Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Add d_main_name to dlang.c
Date: Thu, 09 Jan 2014 18:18:00 -0000	[thread overview]
Message-ID: <87wqi981ef.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CABOHX+cKZ6+1H3DyHw6ZsOZHAu7_pvaE2KyGPqh9DKvC2n3tCg@mail.gmail.com>	(Iain Buclaw's message of "Thu, 9 Jan 2014 13:09:40 +0000")

>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:

Iain> The main program in D is _Dmain (demangled as 'D main') not C 'main'.
Iain> So the logical entry point of the program should be set accordingly.

Iain> 2014-01-09  Iain Buclaw  <ibuclaw@gdcproject.org>

Iain>         * d-lang.h (d_main_name): Add declaration.
Iain>         * d-lang.c (d_main_name): New function.
Iain>         * symtab.c (find_main_name): Add call to d_main_name.

This is ok.

Iain> +static const char D_MAIN[] = "D main";

If D symbols routinely demangle to have spaces in them, then I think
your users may be in for some difficulties using gdb.  Right now I think
linespecs have some hacks to let this work for C++, but I'm not sure how
readily they could be extended to the above.

If it is just the one symbol, then no big deal, there is quoting.

Tom


  reply	other threads:[~2014-01-09 18:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 13:09 Iain Buclaw
2014-01-09 18:18 ` Tom Tromey [this message]
2014-01-09 18:29   ` Iain Buclaw
2014-01-10 17:26     ` Iain Buclaw
2014-01-10 18:57       ` Tom Tromey
2014-01-10 19:36         ` Iain Buclaw
2014-01-10 19:47           ` Tom Tromey
2014-01-18 17:09   ` Iain Buclaw
2014-01-18 18:22     ` Iain Buclaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqi981ef.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ibuclaw@gdcproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox