From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30950 invoked by alias); 9 Oct 2014 08:05:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30938 invoked by uid 89); 9 Oct 2014 08:05:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_PASS,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 09 Oct 2014 08:05:43 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9985cdq021305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Oct 2014 08:05:38 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9985bjo025521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Oct 2014 08:05:37 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9985bZp005439; Thu, 9 Oct 2014 08:05:37 GMT Received: from termi.oracle.com (/10.175.215.93) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Oct 2014 01:05:36 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/9] Add support for DTrace USDT probes to gdb References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <87zjd69wox.fsf@redhat.com> Date: Thu, 09 Oct 2014 08:05:00 -0000 In-Reply-To: <87zjd69wox.fsf@redhat.com> (Sergio Durigan Junior's message of "Wed, 08 Oct 2014 15:40:46 -0400") Message-ID: <87wq894q9x.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00179.txt.bz2 Hi Sergio. > This patch series introduces support in GDB for a new type of probe: > DTrace USDT probes. > > The first three patches do some changes to the existing probe.[ch] > code, fixing some minor problems associated to support several probe > types, having several probes of different types defined in the same > object and supporting the notion of enabling and disabling probes. > > The rest of the patches are the implementation of the new probe type, > including target support for x86_64 targets, a testsuite and > documentation. OK, I think I reviewed all the patches (except the docs). First of all, thanks for doing this! Heh, thanks for the throughout review! I have mixed feelings about the inclusion of this feature. While I obviously agree that support for a new probe type is good, I also don't like the fact that we are talking about a feature that relies on proprietary software (Oracle dtrace) to operate. As you know I am sympathetic with your concerns. Was I in your position I would raise exactly the same point. You mentioned that you were going to try to come up with some way to test this feature using a tweaked asm source. I think this is a good progress already, and I am looking forward to seeing this. Yes, I am working in a .s file that, once compiled and linked, will provide the DOF program corresponding to the testcase. That will not replace dtrace -G for the general usage, and will have to be updated should the testcase change, but at least will allow to test the probe support without having to install proprietary software. Either way, if we decide to include this feature on GDB, you (or someone else from Oracle) will be responsible for it, because we outside Oracle have no way to make sure that it doesn't break. I can certainly take responsibility on it. Having said that, I will wait until you post updated patches with our comments addressed (and hopefully with a nice testcase :-P), and then we can continue this discussion :-). I will post a corrected version of the patch series soon. Thanks again!