From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116711-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 587 invoked by alias); 15 Oct 2014 13:28:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 569 invoked by uid 89); 15 Oct 2014 13:28:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2
X-HELO: userp1040.oracle.com
Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 13:28:07 +0000
Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94])	by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9FDS2X6029213	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 15 Oct 2014 13:28:03 GMT
Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230])	by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s9FDS00R026059	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Wed, 15 Oct 2014 13:28:02 GMT
Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23])	by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9FDS0x4016127;	Wed, 15 Oct 2014 13:28:00 GMT
Received: from termi.oracle.com (/62.156.150.204)	by default (Oracle Beehive Gateway v4.0)	with ESMTP ; Wed, 15 Oct 2014 06:28:00 -0700
From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'.
References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com>	<1412961772-16249-4-git-send-email-jose.marchesi@oracle.com>	<87eguaqy94.fsf@redhat.com>
Date: Wed, 15 Oct 2014 13:28:00 -0000
In-Reply-To: <87eguaqy94.fsf@redhat.com> (Sergio Durigan Junior's message of	"Tue, 14 Oct 2014 14:53:11 -0400")
Message-ID: <87wq81h33y.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00387.txt.bz2


    > +/* Helper function that parses a probe linespec of the form [PROVIDER
    > +   [PROBE [OBJNAME]]] from the provided string STR.  */
    > +
    > +static void
    > +parse_probe_linespec (const char *str, char **provider,
    > +		      char **probe_name, char **objname)
    > +{
    > +  *probe_name = *objname = NULL;
    > +  
    > +  *provider = extract_arg_const (&str);
    > +  if (*provider)
    
    Ops, another implicit comparison :-).

I changed these comparisons to be explicit.