From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111767 invoked by alias); 8 Jun 2016 02:14:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111756 invoked by uid 89); 8 Jun 2016 02:14:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy1-pub.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1-pub.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 08 Jun 2016 02:14:27 +0000 Received: (qmail 22273 invoked by uid 0); 8 Jun 2016 02:14:25 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy1.mail.unifiedlayer.com with SMTP; 8 Jun 2016 02:14:25 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 42EM1t0012f2jeq012EQdu; Tue, 07 Jun 2016 20:14:25 -0600 X-Authority-Analysis: v=2.1 cv=KpLehwmN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=20KFwNOVAAAA:8 a=ntcLCJ2CpJfYHR4S-WgA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from [65.128.48.199] (port=49506 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bAT0e-0001Ph-J2; Tue, 07 Jun 2016 20:14:20 -0600 From: Tom Tromey To: Pedro Alves Cc: Yao Qi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-4-git-send-email-tom@tromey.com> <86mvmywgj1.fsf@gmail.com> Date: Wed, 08 Jun 2016 02:14:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 7 Jun 2016 15:03:36 +0100") Message-ID: <87wpm05sw7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bAT0e-0001Ph-J2 X-Source-Sender: (bapiya) [65.128.48.199]:49506 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00146.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So IMHO, something like "la_sniff_from_mangled_name" would be Pedro> even clearer. I made this change. Pedro> BTW, what do we do with the resulting demangled name? Is Pedro> there some sort of guideline for options to pass to the demangler? Pedro> Some sort of output that we're aiming for? The resulting name, if any, is put into a symbol by symbol_set_names. (I didn't change this area, just made it so the existing code could be factored into per-language methods.) So, it should be whatever is appropriate for a symbol. I think this area is still a bit messy. IIRC there are some weird demangling differences between psymbols and full symbols, and there is still a hack for Java in symbol_set_names. Tom