From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6210 invoked by alias); 30 Sep 2016 15:18:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6196 invoked by uid 89); 30 Sep 2016 15:18:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 30 Sep 2016 15:17:56 +0000 Received: (qmail 16888 invoked by uid 0); 30 Sep 2016 15:17:54 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy6.mail.unifiedlayer.com with SMTP; 30 Sep 2016 15:17:54 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id prHr1t0112f2jeq01rHuJJ; Fri, 30 Sep 2016 09:17:54 -0600 X-Authority-Analysis: v=2.1 cv=ffo+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=20KFwNOVAAAA:8 a=Wvb7btbuqRZLhj1CgxsA:9 a=ZIF1_bv2k-0A:10 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:36890 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bpzZP-0001JA-EB; Fri, 30 Sep 2016 09:17:51 -0600 From: Tom Tromey To: Pedro Alves Cc: Trevor Saunders , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 02/22] Use RAII to save and restore scalars References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-3-git-send-email-tom@tromey.com> <20160927085937.com7c7ct4wuchzpg@ball> Date: Fri, 30 Sep 2016 15:44:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 30 Sep 2016 02:17:11 +0100") Message-ID: <87wphtfmcj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bpzZP-0001JA-EB X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:36890 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00433.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> scoped_restore scope = make_scoped_restore (&some_global); I made this change. One minor oddity is that the 2-argument form of make_scoped_restore required a copy constructor in the scoped_restore_tmpl subclass. I think that's harmless though. Tom