From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126850 invoked by alias); 6 Oct 2016 02:53:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126840 invoked by uid 89); 6 Oct 2016 02:53:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=STATE X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 06 Oct 2016 02:53:26 +0000 Received: (qmail 28580 invoked by uid 0); 6 Oct 2016 02:53:25 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy8.mail.unifiedlayer.com with SMTP; 6 Oct 2016 02:53:25 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id s2tL1t0082f2jeq012tPAU; Wed, 05 Oct 2016 20:53:23 -0600 X-Authority-Analysis: v=2.1 cv=D9zUdJhj c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=J6xSk6EymFHjeXsHBmsA:9 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:32988 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bryoD-0005rT-FG; Wed, 05 Oct 2016 20:53:21 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 09/22] Remove make_cleanup_restore_current_ui References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-10-git-send-email-tom@tromey.com> <8f9af0b666b9bd9c8305631c607cd591@simark.ca> Date: Thu, 06 Oct 2016 02:53:00 -0000 In-Reply-To: <8f9af0b666b9bd9c8305631c607cd591@simark.ca> (Simon Marchi's message of "Sat, 01 Oct 2016 00:29:27 -0400") Message-ID: <87wphmdw80.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bryoD-0005rT-FG X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:32988 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00103.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> We are targetting C++98, aren't we? Or is it C++03? Either way, Simon> nullptr appeared in C++11, so I guess we can't use it. Yep. Fixed. >> #define SWITCH_THRU_ALL_UIS(STATE) \ Simon> You can remove STATE here. I am surprised the preprocessor doesn't Simon> care about the missing argument in macro references. Maybe that's a GNU extension. I forget. But anyway I've fixed it. Tom