From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117668 invoked by alias); 31 Oct 2016 03:07:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116394 invoked by uid 89); 31 Oct 2016 03:06:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:851 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 31 Oct 2016 03:06:03 +0000 Received: (qmail 3301 invoked by uid 0); 31 Oct 2016 03:06:02 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy9.mail.unifiedlayer.com with SMTP; 31 Oct 2016 03:06:02 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 235x1u0122f2jeq01360VY; Sun, 30 Oct 2016 21:06:00 -0600 X-Authority-Analysis: v=2.1 cv=PIacp5aC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=VnNF1IyMAAAA:8 a=CCpqsmhAAAAA:8 a=djRGWRFCtvMbeSfyiB8A:9 a=Mr9POxIuc7cA:10 a=skCgnbhlp52w9zbo2JeP:22 a=ul9cdbp4aOFLsgKbc677:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:32910 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c12v8-0001pa-TS; Sun, 30 Oct 2016 21:05:58 -0600 From: Tom Tromey To: "Ulrich Weigand" Cc: qiyaoltc@gmail.com (Yao Qi), gdb-patches@sourceware.org (gdb-patches@sourceware.org), tom@tromey.com (Tom Tromey) Subject: Re: set_value_component_location in apply_val_pretty_printer References: <20161028185834.0145C10B927@oc8523832656.ibm.com> Date: Mon, 31 Oct 2016 03:07:00 -0000 In-Reply-To: <20161028185834.0145C10B927@oc8523832656.ibm.com> (Ulrich Weigand's message of "Fri, 28 Oct 2016 20:58:33 +0200 (CEST)") Message-ID: <87wpgpusiy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c12v8-0001pa-TS X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:32910 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00851.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: >> It was added by Tom in >> https://sourceware.org/ml/gdb-patches/2010-06/msg00132.html >> There wasn't much information in email and ChangeLog. What Ulrich wrote is better than anything I was likely to write. Ulrich> That's why all the val_print routines not just receive the Ulrich> original value object (which remains unchanged even while Ulrich> recursing through subobjects), but also an idenfication of Ulrich> the subobject that is to be processed: this is a pair of Ulrich> offset and type, and means, the subobject of type "type" Ulrich> starting at offset "offset" within the larger object. I've thought for a long time that val_print should just be removed, and only full values should be passed around. Tom