From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82670 invoked by alias); 28 Nov 2016 18:57:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82646 invoked by uid 89); 28 Nov 2016 18:57:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sergio, Sergio, Hx-languages-length:1788, racy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Nov 2016 18:57:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 071F861B90; Mon, 28 Nov 2016 18:57:12 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uASIvBDV016046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 28 Nov 2016 13:57:11 -0500 From: Sergio Durigan Junior To: Luis Machado Cc: Subject: Re: [PATCH v2 0/8] Fix gdb's testsuite test names References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> X-URL: http://blog.sergiodj.net Date: Mon, 28 Nov 2016 18:57:00 -0000 In-Reply-To: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> (Luis Machado's message of "Fri, 25 Nov 2016 14:53:56 -0600") Message-ID: <87wpfn8mbd.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00922.txt.bz2 On Friday, November 25 2016, Luis Machado wrote: > Changes in v2: > > * Patch 1/8 in v1 is now patch 8/8 in v2, due to organization issues. Patch 8/8 > does a few additional things in v2. Patches 2~8 in v1 are now 1~7 in v2. > > Patch 1/8 and Patch 2/8 > ========= > > * Fixed spurious whitespaces. > > Patch 8/8 > ========= > > * Updated compilation failure message and replaced existing ones to keep them > standard. > > All other patches have no meaningful changes. > > v1 can be found here: https://sourceware.org/ml/gdb-patches/2016-11/msg00813.html > > --- > > I was going to go with a single patch for this, but i kept hitting other > cases where i needed to adjust the regular expressions and substitution rules. > > I then decided to have a series with each individual piece that should make it > easier to review as well. The changes are all pretty mechanical, but it would > be nice to have another pair of eyes looking at these to make sure nothing > incorrect got through. > > The first patch handles the "testfile as test name" problem. The rest of the > series handles test names starting with uppercase. Thanks for the patch, Luis! It would be awesome to also have unique names for each testcase, but I realize this is a much more difficult task :-). Just a heads up for everyone: when this patch series is pushed, we are probably going to see a lot of known XFAILs return on the BuildBot reports. This is due to the way we identify the XFAILs, using their whole name in a case-sensitive manner. The new XFAILs will be detected during the weekend, when the racy tests run. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/