From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91367 invoked by alias); 23 Dec 2016 19:05:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91343 invoked by uid 89); 23 Dec 2016 19:05:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=raii, sk:dwarf2_, RAII, Hx-spam-relays-external:10.0.90.82 X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 23 Dec 2016 19:05:11 +0000 Received: (qmail 27865 invoked by uid 0); 23 Dec 2016 19:05:09 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 23 Dec 2016 19:05:09 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id PX541u01c2f2jeq01X574i; Fri, 23 Dec 2016 12:05:07 -0700 X-Authority-Analysis: v=2.1 cv=U4oBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=k6Un0v-pYY7N4a_URqkA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 75-171-175-27.hlrn.qwest.net ([75.171.175.27]:45366 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cKV9O-0006XH-6d; Fri, 23 Dec 2016 12:05:06 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 6/8] Use value_freer in dwarf2_evaluate_loc_desc_full References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-7-git-send-email-tom@tromey.com> <06e2b7b1-feca-29f7-7e49-e05f01d05485@redhat.com> <87bmwgez57.fsf@tromey.com> Date: Fri, 23 Dec 2016 19:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 20 Dec 2016 14:49:07 +0000") Message-ID: <87wpeq5uvy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cKV9O-0006XH-6d X-Source-Sender: 75-171-175-27.hlrn.qwest.net (bapiya) [75.171.175.27]:45366 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00404.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In pondering a bit more over this, I wonder whether Pedro> adding a "scoped_" to go with scoped_restore etc., would make Pedro> it a bit clearer to readers that this is a RAII type. Then Pedro> also considering value_release_to_mark, I wonder would an Pedro> API/naming like this: [...] Pedro> Would this result in clearer client code? IMHO, yes, but WDYT? It looks good to me. I've made this change and I'll send the new patches soon. FYI I've only implemented the subset of the proposed API that was needed by the patches I have. Tom