From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90283 invoked by alias); 7 Jun 2017 21:00:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90203 invoked by uid 89); 7 Jun 2017 21:00:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 21:00:05 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB4E4C04B302 for ; Wed, 7 Jun 2017 21:00:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BB4E4C04B302 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BB4E4C04B302 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91B82174B7; Wed, 7 Jun 2017 21:00:05 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-4-sergiodj@redhat.com> <0e95d746-9293-3301-15ed-84d6c4280116@redhat.com> <87poep8zdg.fsf@redhat.com> Date: Wed, 07 Jun 2017 21:00:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 7 Jun 2017 11:15:44 +0100") Message-ID: <87wp8no6nf.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00177.txt.bz2 On Wednesday, June 07 2017, Pedro Alves wrote: > On 05/31/2017 04:43 AM, Sergio Durigan Junior wrote: >> >>>> >> index 4ea7913..8aa85db 100644 >>>> >> --- a/gdb/gdbserver/configure.ac >>>> >> +++ b/gdb/gdbserver/configure.ac >>>> >> @@ -462,7 +462,9 @@ esac], >>>> >> >>>> >> if $want_ipa ; then >>>> >> if $have_ipa ; then >>>> >> - IPA_DEPFILES="$ipa_obj" >>>> >> + # Needed because safe_strerror's definition is host-dependent >>> > >>> > Why do we end up needing safe_strerror in the IPA in the first place? >> This is needed because I moved the definition of >> trace_start_error_with_name from the old gdb/fork-child.c to >> common/common-utils.c. This function which uses safe_strerror, and >> common/common-utils.c is compiled by IPA. >> >> An option would be to keep these trace_start_error.* functions in >> nat/fork-inferior.c, but I think it is more logical to keep them on >> common-utils.c. > > I'd rather not add them to the IPA. The least unnecessary code > is included in that library the better, because it is injected > into the target process. So keeping them in fork-inferior.c > sounds better. OK, fair enough. >> Now, I can obviously expand the comment if that's what you meant. >> >>>> >> + strerror_obj="`echo $srv_host_obs | sed 's/\(.*-strerror\)\.o/\1-ipa.o/'`" >>>> >> + IPA_DEPFILES="$ipa_obj $strerror_obj" >>>> >> extra_libraries="$extra_libraries libinproctrace.so" >>>> >> else >>>> >> AC_MSG_ERROR([inprocess agent not supported for this target]) >>> > >>> > >>> > >>>> >> -#if defined(__UCLIBC__) && defined(HAS_NOMMU) >>>> >> - pid = vfork (); >>> > >>> > Does fork_inferior end up always using vfork on no-MMU >>> > ports somehow? >> Sorry, I am not sure. How would I go about finding that? > > I'm not sure either. configure.ac for anything fork related? > Look at git blame history around those lines, see what other > bits were touched at the same time? gdbserver clearly cares about > being built for no-MMU ports, so the new code must too. We can't > just delete that support without an alternative. As explained earlier in private, I'm sorry for the confusion. I totally misunderstood your question; I thought you were suggesting to *remove* the defines, but you actually wants to know why they were removed from the code... Obviously! Well, as I said, I totally agree that they should be kept and I will put them back. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/