From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96487 invoked by alias); 4 Nov 2017 16:25:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96475 invoked by uid 89); 4 Nov 2017 16:25:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.125.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Nov 2017 16:25:07 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 77DFA4011D5DE for ; Sat, 4 Nov 2017 11:25:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id B1FqeorXxDL8rB1Fqedpet; Sat, 04 Nov 2017 11:25:06 -0500 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:36594 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eB1Fq-003nbR-5z; Sat, 04 Nov 2017 11:25:06 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-7-tom@tromey.com> <368bfe6be1612beb89c174c35e0cc73a@polymtl.ca> <87efpfuwnx.fsf@tromey.com> Date: Sat, 04 Nov 2017 16:25:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 03 Nov 2017 13:19:53 -0400") Message-ID: <87wp36t3j2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eB1Fq-003nbR-5z X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:36594 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00095.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> This also fixes an earlier memory leak regression, by changing >> "string" to be a std::string. Simon> LGTM, though I would suggest using string_print, I think it would be Simon> more readable. I made this change. Tom