From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103517 invoked by alias); 25 Apr 2018 22:27:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103483 invoked by uid 89); 25 Apr 2018 22:27:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=simon.marchi@ericsson.com, simonmarchiericssoncom X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Apr 2018 22:27:31 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 6269F929C62 for ; Wed, 25 Apr 2018 17:27:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BSsrf8GqQlAdrBSsrfi5VA; Wed, 25 Apr 2018 17:27:29 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:47070 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fBSsr-002xcE-5x; Wed, 25 Apr 2018 17:27:29 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH 2/2] Use XOBNEW when possible References: <1524685183-5553-1-git-send-email-simon.marchi@ericsson.com> <1524685183-5553-2-git-send-email-simon.marchi@ericsson.com> Date: Wed, 25 Apr 2018 22:27:00 -0000 In-Reply-To: <1524685183-5553-2-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 25 Apr 2018 15:39:43 -0400") Message-ID: <87wowu7whb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fBSsr-002xcE-5x X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:47070 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00528.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Since XOBNEW is now poisoned to prevent using it with Simon> non-trivially-constructible objects, it is worth using it over plain Simon> obstack_alloc. This patch changes the locations I could find where we Simon> can do that change easily. Thanks. Simon> - struct hppa_objfile_private *priv; Simon> + hppa_objfile_private *priv Simon> + = XOBNEW (&objfile->objfile_obstack, hppa_objfile_private); Simon> - priv = (struct hppa_objfile_private *) Simon> - obstack_alloc (&objfile->objfile_obstack, Simon> - sizeof (struct hppa_objfile_private)); Simon> set_objfile_data (objfile, hppa_objfile_priv_data, priv); Simon> memset (priv, 0, sizeof (*priv)); Maybe ones that memset should be using OBSTACK_ZALLOC. Simon> + e = XOBNEW (&mdebugread_objfile->objfile_obstack, Simon> + mdebug_extra_func_info); Simon> memset (e, 0, sizeof (struct mdebug_extra_func_info)); There seem to be a few. Tom