From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128735 invoked by alias); 15 Jul 2018 18:09:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128710 invoked by uid 89); 15 Jul 2018 18:09:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bother, wondering, legacy X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Jul 2018 18:09:40 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 07ED85A55 for ; Sun, 15 Jul 2018 13:09:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id elSkfeT98SjJAelSkfRsmU; Sun, 15 Jul 2018 13:09:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XdCxxfMqTghwzv2Q9bsjR7JjxxBG+EF+p91vP6mP1/I=; b=V4QwAF4T9DtKfunWM/DBiZi2kN o7y3zhUGN6HGvVNe5zFqznNS/R+vxykbtp/hgqE2z7sstCHy3ienehvhm/qWFNKaDnYYMfDpVo2Ig LHNsJmYcmn+hLh08HOsSDGLp+; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36098 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1felSj-000dZg-Q6; Sun, 15 Jul 2018 13:09:37 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 21/42] Move the context stack to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-22-tom@tromey.com> <8337949d-a26d-4e3f-e75d-eccda88d74f6@redhat.com> Date: Sun, 15 Jul 2018 18:09:00 -0000 In-Reply-To: <8337949d-a26d-4e3f-e75d-eccda88d74f6@redhat.com> (Keith Seitz's message of "Fri, 6 Jul 2018 10:30:48 -0700") Message-ID: <87wotw8j6n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00467.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I can't help but think these function names, which could appear in Keith> several source files, seem a little vague or collision-prone Keith> (conceptually)... Would it be worth it for these (and perhaps all Keith> similar buildsym.h get_* functions) to be namespaced or further Keith> prefixed, e.g., buildsym_[get_]current_context_stack or Keith> buildsym::get_current_context_stack? I'm not going to suggest [Dare I Keith> say, "require?"] any changes -- I'm just wondering "aloud." I think it would be a reasonable follow-up patch; though seeing that these things are all in the legacy API, I guess I'd be inclined not to bother. >> +/* Non-zero if the context stack is empty. */ Keith> ^^^^^^^^ >> + >> +extern bool outermost_context_p (); Keith> Since this (now) returns bool, please use boolean in comment. Fixed. >> + >> +/* Return the top of the context stack, or nullptr if there is >> + entry. */ >> + >> +extern struct context_stack *get_current_context_stack (); >> + Keith> Typo in "if there is entry." Fixed. Tom