From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62927 invoked by alias); 16 Oct 2018 21:39:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62884 invoked by uid 89); 16 Oct 2018 21:39:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sleeping, H*RU:100.42.49.20, H*RU:sk:cm17.we, Hx-spam-relays-external:sk:cm17.we X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.199.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Oct 2018 21:39:07 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id E100F400E7EE6 for ; Tue, 16 Oct 2018 15:46:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CX3OgvXLLPvAdCX3QgjdXm; Tue, 16 Oct 2018 16:39:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I2FGicYHzTorUDvhqe1TQ40BoChxKcds5b5VGVni5ZE=; b=Hez/qp0qJFpgjC+ynJxugsuwa1 hv2iPL2mofiheBzJuar7VdW5NTtm/AM1dws7APrNjn/QCdaXC8YLr3rrUanqO+jvxDjSXpjvOpXM6 32vry/l4Y1Ct61Wk1ZLkgY1+/; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:33656 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gCX3O-003seA-82; Tue, 16 Oct 2018 16:39:02 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Release the GIL while running a gdb command or expression References: <20181010202233.17985-1-tom@tromey.com> <6c7d1b6d-2d7a-dcaf-8d20-615bfb474af9@redhat.com> <871s8qcab9.fsf@tromey.com> <4aa9c215-9b86-40f9-37e9-d96121e80736@redhat.com> Date: Tue, 16 Oct 2018 21:39:00 -0000 In-Reply-To: <4aa9c215-9b86-40f9-37e9-d96121e80736@redhat.com> (Pedro Alves's message of "Tue, 16 Oct 2018 15:51:27 +0100") Message-ID: <87woqhbmh6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00353.txt.bz2 Pedro> Hopefully it'll be possible to tighten the test a bit to avoid that. I should have read the test more closely. It doesn't do what it claims to do at all. The only way the test can fail is if one "Hello" or "Sleeping" line comes with the wrong number: set n $expect_out(1,string) if { $hello_last + 1 != $n } { fail $test But this just isn't possible. Also the Python code is calling print on a gdb stream in a background thread, which is a no-no. I could change the test to do some kind of counting in a background thread. But that would introduce a race, which is what I was concerned about up-thread... I couldn't think of a non-racy way to test this. Maybe that's better than nothing. Anyway, we're back to square one and I don't know what to do really. Tom