From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62307 invoked by alias); 30 Nov 2018 15:37:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62290 invoked by uid 89); 30 Nov 2018 15:37:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.47.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 15:37:45 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id B69C340121B70 for ; Fri, 30 Nov 2018 09:37:43 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SkrPg3e0waSeySkrPgFnkx; Fri, 30 Nov 2018 09:37:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bbGDdfRMfaXdTbWiK6NcDHb+/GzY0GAV8fXdQNKOQXo=; b=RGW+t0V22KKbxBD4euz/SY6j6n cNXO5QB9HNJRjA0KJQ/iO71hvo2a0TGtECaWuDbZD/2P8zsGm9PdwNmr9c4gT22Ibe0TF//3L4+3u fQFabvsQjBh30MqOPvmp1VDgx; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:59454 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSkrP-001AfI-E3; Fri, 30 Nov 2018 09:37:43 -0600 From: Tom Tromey To: Wei-min Pan Cc: Tom Tromey , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH PR gdb/20057] Internal error on trying to set {char[]}$pc="string" References: <1516844738-79996-1-git-send-email-weimin.pan@oracle.com> <20180125041431.tghhxefsgxnxh3l3@adacore.com> <1dfc87b0-353d-3388-a427-fee247dc79a5@oracle.com> <20180131074526.rqbsjxyxp3p26js5@adacore.com> <1d28e9c6-6377-0c46-6bce-1dc25a7fa2d5@oracle.com> <20180201075955.mnqxzmw4ktuy3f5d@adacore.com> <20181114235153.GB4336@adacore.com> <87tvjzae0u.fsf@tromey.com> <82a6d5fc-7152-88aa-115b-c767fd3f3569@oracle.com> <87lg5ba6vl.fsf@tromey.com> <4107cd46-1978-93a8-1f54-6e1622ffe191@oracle.com> Date: Fri, 30 Nov 2018 15:37:00 -0000 In-Reply-To: <4107cd46-1978-93a8-1f54-6e1622ffe191@oracle.com> (Wei-min Pan's message of "Thu, 29 Nov 2018 15:26:13 -0800") Message-ID: <87woou1sqh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00568.txt.bz2 >>>>> ">" == Wei-min Pan writes: >> Let's use an example: >> (gdb) p {char []}$pc >> if the element type "char" is defined in the program, i.e. it has an >> objfile, lookup_array_range_type sets the "index type" with that >> objfile's builtin_int. Thanks. >> Both resolve_dynamic_array and resolve_dynamic_range call copy_type to >> allocate a type and yes modify it to represent a static version of the array >> type from lookup_array_range_type() above. Ok, I see. Removing the assertion does seem ok then. thanks, Tom