Re: [RFA] Fix leaks in macro definitions.

Simon Marchi
2019-01-15T17:49:23Z

On 2019-01-15 12:15, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> Would you consider that a bug in the splay tree implementation?
> Simon> Should it use the new key and free the old one with the key
> Simon> deallocation function?
>
> Yes, I would think so as well, given that we pass key- and
> value-deletion functions to splay_tree_new_with_allocator.

Ok. Fixing this in the splay tree code would be a quite long task
(reviewing all usages in binutils-gdb and gcc, I don't think this code
is available externally?), so I am ok with this patch which fixes the
issue in the mean time. Tom?

Simon