From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18327 invoked by alias); 14 Feb 2019 22:49:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18304 invoked by uid 89); 14 Feb 2019 22:49:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 22:49:49 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id DCDF2E100D0 for ; Thu, 14 Feb 2019 16:49:47 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uPpDgoTMs4FKpuPpDg8lmM; Thu, 14 Feb 2019 16:49:47 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jJp0FENClHGaW76MUEuiYi69Jwm5+/UL5uUlNK1ar84=; b=h+gf0QDzN/mCKgbG9qLyq4KPQt qnSB67EN4vVfMNZ7dbm5R7/JgMzuUAXA2GxsBkubOhTO5rZ3m61m8hsctH2cRems6cdUvWvmE4WOO wsC1h9LVnD8CaAcZKq40om+ed; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:58150 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1guPpD-002cmz-Kd; Thu, 14 Feb 2019 16:49:47 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/20] Remove cleanups References: <20190213212927.9474-1-tom@tromey.com> <75686c17-b637-2403-09ab-b362d85a9c04@FreeBSD.org> <875ztm4e9s.fsf@tromey.com> <2c0c044c-19c5-824e-234d-f5e63d076c85@FreeBSD.org> Date: Thu, 14 Feb 2019 22:49:00 -0000 In-Reply-To: <2c0c044c-19c5-824e-234d-f5e63d076c85@FreeBSD.org> (John Baldwin's message of "Thu, 14 Feb 2019 12:38:04 -0800") Message-ID: <87wom20yut.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00245.txt.bz2 >>>>> "John" == John Baldwin writes: John> I think a second pass is fine unless its trivial to re-run the script. I John> second Pedro's suggestion about trying 'const' as well. "const" worked fine. For the renaming I've opted for a second patch, since it was simpler to deal with the ChangeLog this way. I don't plan to check this in until after other things have landed and the 8.3 branch has been made. Tom