From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95363 invoked by alias); 19 Feb 2019 15:19:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95341 invoked by uid 89); 19 Feb 2019 15:19:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=2014, mar, Hx-languages-length:1251, Mar X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.46.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Feb 2019 15:19:22 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4818B4011DFFB for ; Tue, 19 Feb 2019 09:19:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id w7B2g5LBD4FKpw7B2gOhQx; Tue, 19 Feb 2019 09:19:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lAD9VbNxfRmwk5XaRujux2tEQolOhkeRwUahV6jObsc=; b=NZezGuzOOmgDF1ULEMPGoBuKD2 13QK2GQir/XIgjSiAEJOda08f54fFRvwDYCxqVaVUbzYJJolSdamRLeUiVedbkj2UOuTImN0dqPSx Y1m9Rk2zw2H1n7uYKU7nBYhk4; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:34592 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gw7B2-001snx-09; Tue, 19 Feb 2019 09:19:20 -0600 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org, Tom Tromey , Ulrich Weigand Subject: Re: [PATCH 2/4] Define gdb.Value(bufobj, type) constructor References: <20190218075816.6f67f3d9@f29-4.lan> <20190218080636.02e3847f@f29-4.lan> <87h8d0lnq2.fsf@tromey.com> <20190218175720.6cf45742@f29-4.lan> Date: Tue, 19 Feb 2019 15:19:00 -0000 In-Reply-To: <20190218175720.6cf45742@f29-4.lan> (Kevin Buettner's message of "Mon, 18 Feb 2019 17:57:20 -0700") Message-ID: <87wolvu7pk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-02/txt/msg00303.txt.bz2 >>>>> "Kevin" =3D=3D Kevin Buettner writes: >> However, this seems like a decision to make consciously. >> I'm not completely sure how to proceed, though one idea might be to find >> the most recent Python 2.[456] compatibility patch and then asking the >> author whether this support is still relevant. Kevin> I didn't know of that compatibility patch, though I'll try to track = it Kevin> down. (A pointer would be appreciated if you have one handy.) I just recall it happening from time to time. Using: git log --grep 'Python 2\.[4-6]' ... shows a couple maybe uninteresting patches, followed by: commit 49840f2a6669ae2366c522da41edf615785b3626 Author: Ulrich Weigand Date: Sun Mar 16 15:01:24 2014 +0100 Fix Python 2.4 build break =20=20=20=20 This fixes a build failure against Python 2.4 by casting away "const" on the second argument to PyObject_GetAttrString. Similar casts to support Python 2.4 were already present in a number of other places. =20=20=20=20 gdb/ 2014-03-16 Ulrich Weigand=C2=A0 =20=20=20=20 * python/py-value.c (get_field_flag): Cast flag_name argument to PyObject_GetAttrString to support Python 2.4. So, I've CC'd Ulrich. Tom