From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52854 invoked by alias); 26 Feb 2019 15:08:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52836 invoked by uid 89); 26 Feb 2019 15:08:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:634, probable X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.201.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Feb 2019 15:08:52 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id D81654010CC2B for ; Tue, 26 Feb 2019 08:23:46 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yeLggPN3U90onyeLggk8gL; Tue, 26 Feb 2019 09:08:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BBHS+eFzlfS1H18APXCloDDiNEbERqlKphNgMFFRUdo=; b=AetZHeRJWLI0TqqiTqmyAJxyE2 4Ppa3mlbKgIqqEYwCfmfxaWWCJDeKvOiYZnzS1bQncBCuGapxXuJjAXq77gRcEbqkjO/5P0DshYJQ SNwR8URiLiraM54cKdE1U6Ebz; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:60848 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gyeLg-0027Mj-9e; Tue, 26 Feb 2019 09:08:48 -0600 From: Tom Tromey To: Simon Marchi Cc: Jordan Rupprecht , gdb-patches@sourceware.org, Eric Christopher , David Blaikie , dje@google.com Subject: Re: [PATCH] [dwarf2read] Fix crash when loading dwp files: calculate num_sections based on actual section indices, not just the number of sections. References: <439bf4f6859a539472a2e51a028b9503@polymtl.ca> <20190225201715.144927-1-rupprecht@google.com> <1b6df15638153631ea87fa1bc7c24dd2@polymtl.ca> Date: Tue, 26 Feb 2019 15:08:00 -0000 In-Reply-To: <1b6df15638153631ea87fa1bc7c24dd2@polymtl.ca> (Simon Marchi's message of "Mon, 25 Feb 2019 15:55:44 -0500") Message-ID: <87wolmlh8g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00433.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> - dwp_file->num_sections = bfd_count_sections (dwp_file->dbfd) + 1; >> + dwp_file->num_sections = elf_numsections (dwp_file->dbfd); Simon> I have tweaked the original commit message a bit and pushed. Simon> Thanks again for the patch. I wonder if there's any way to reach this with a non-ELF objfile -- Mach-O seems probable. I think we also handle DWARF on AIX (ECOFF IIRC) but I don't know if that does dwp. Tom