From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44167 invoked by alias); 24 Apr 2019 20:51:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44150 invoked by uid 89); 24 Apr 2019 20:51:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1029 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.126.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Apr 2019 20:51:53 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 09EBB400CB67D for ; Wed, 24 Apr 2019 15:10:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JOrvhbqmX2PzOJOrvh7ZvS; Wed, 24 Apr 2019 15:51:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zMXvgXN7HvQhfjKjnbLE1epME5E+wydzYIQ50771qfI=; b=ja7j8kQfS9ETqGQ65P/04UD0MW WVeQlOQI21fI2WpcXI3xsVzA1EH3LTo6eFJHeXu2WK5OdsrKf17BjaU+WBHqUtOz0b/5sV9QBbNbh CjEF64v0L/RLVJQ8ZEWW9Nt5O; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:55082 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJOrv-0040xr-Hw; Wed, 24 Apr 2019 15:51:51 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/4] Add previous_saved_command_line to allow a command to repeat a previous command. References: <20190420212153.30934-1-philippe.waroquiers@skynet.be> <20190420212153.30934-2-philippe.waroquiers@skynet.be> Date: Wed, 24 Apr 2019 20:51:00 -0000 In-Reply-To: <20190420212153.30934-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 20 Apr 2019 23:21:50 +0200") Message-ID: <87wojjdt3t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00501.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> +/* The previous last command line executed on the console. Used for command Philippe> + repetitions when a command want to relaunch the previously launched Philippe> + command. We need this as when a command is running, saved_command_line Philippe> + already contains the line of the currently executing command. */ Philippe> +char *previous_saved_command_line; Is there a way to make this static? Like have repeat_previous return the desired value or something like that? Philippe> +void Philippe> +repeat_previous (void) You can use () instead of (void) in C++. Philippe> + /* We cannot free saved_command_line, as this line is being executed, Philippe> + so swap it with previous_saved_command_line. */ Philippe> + previous_saved_command_line = saved_command_line; Philippe> + saved_command_line = tmp; Just use std::swap here. Tom