From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/4] Improve "show style", use style in "help" and "apropos".
Date: Fri, 31 May 2019 20:35:00 -0000 [thread overview]
Message-ID: <87woi6nyzc.fsf@tromey.com> (raw)
In-Reply-To: <20190531131903.21203-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Fri, 31 May 2019 15:18:59 +0200")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> Improve "show style", have "help" and "apropos" styling their output.
Philippe> This patch series improves the "show style" output to let the
Philippe> user visualize all the styles with one command.
Philippe> "help" and "apropos" commands are now styling their output.
Philippe> The "help" testing is also better factorized.
This all seems basically ok, just a few nits here and there.
However, it's missing any testing of the actual styling. I think that
should be done.
Tom
next prev parent reply other threads:[~2019-05-31 20:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 13:19 Philippe Waroquiers
2019-05-31 13:19 ` [RFA 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' Philippe Waroquiers
2019-05-31 20:10 ` Tom Tromey
2019-06-01 8:47 ` Philippe Waroquiers
2019-06-03 14:21 ` Tom Tromey
2019-05-31 13:19 ` [RFA 3/4] Update tests following changes to "help" and "apropos" Philippe Waroquiers
2019-05-31 20:34 ` Tom Tromey
2019-05-31 13:19 ` [RFA 4/4] Document in NEWS and gdb.texinfo the "help", "apropos" and "show style" changes Philippe Waroquiers
2019-05-31 13:46 ` Eli Zaretskii
2019-05-31 13:19 ` [RFA 2/4] Improve usability and/or readibility of help and apropos output Philippe Waroquiers
2019-05-31 20:22 ` Tom Tromey
2019-05-31 20:35 ` Tom Tromey [this message]
2019-06-18 13:09 ` [RFA 0/4] Improve "show style", use style in "help" and "apropos" Pedro Alves
2019-06-18 16:04 ` Tom Tromey
2019-06-18 20:11 ` Philippe Waroquiers
2019-06-18 20:46 ` Tom Tromey
2019-06-18 20:53 ` Philippe Waroquiers
2019-06-18 20:58 ` Philippe Waroquiers
2019-06-18 22:40 ` Pedro Alves
2019-06-19 0:25 ` Philippe Waroquiers
2019-06-19 19:44 ` Tom Tromey
2019-06-19 19:26 ` Tom Tromey
2019-06-19 22:56 ` Pedro Alves
2019-06-20 14:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woi6nyzc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox