From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117378 invoked by alias); 23 Jul 2019 15:53:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117369 invoked by uid 89); 23 Jul 2019 15:53:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*Ad:U*tromey X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jul 2019 15:53:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DCCFC116BC4; Tue, 23 Jul 2019 11:53:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2HptaQ97k8EM; Tue, 23 Jul 2019 11:53:03 -0400 (EDT) Received: from murgatroyd (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 5DF17116BC0; Tue, 23 Jul 2019 11:53:03 -0400 (EDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue References: <20190627145235.21222-1-tromey@adacore.com> <20190627145235.21222-2-tromey@adacore.com> <290eda910e16f817e2ba298b17db7254@polymtl.ca> Date: Tue, 23 Jul 2019 15:53:00 -0000 In-Reply-To: <290eda910e16f817e2ba298b17db7254@polymtl.ca> (Simon Marchi's message of "Sat, 20 Jul 2019 19:17:23 -0400") Message-ID: <87wog8vjc1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00540.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2019-06-27 10:52, Tom Tromey wrote: >> This changes SYMBOL_VALUE_ADDRESS to be an lvalue. The symbol readers >> generally assign using this, so this also introduces >> SET_SYMBOL_VALUE_ADDRESS and updates the readers. Making this change >> is useful in a subsequent patch, which redefined SYMBOL_VALUE_ADDRESS. Simon> Is the title (and commit message) backwards? SYMBOL_VALUE_ADDRESS(x) Simon> is currently an lvalue, and you are making it a not-lvalue, no? Yeah, I meant rvalue. I've updated the patch to fix this. Tom